Extend Widget time schema with support for new fixed_span and live_span object #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e3b962 to
749b90b
Compare
36203ac to
688245e
Compare
40376fb to
b73dfe4
Compare
Co-authored-by: jack-edmonds-dd <jack.edmonds@datadoghq.com>
…es' into datadog-api-spec/test/bruce.tu/DBNBK-116-Extend-Widget.TIME-schema additional prop changes
0964203 to
7b01738
Compare
…es' into datadog-api-spec/test/bruce.tu/DBNBK-116-Extend-Widget.TIME-schema merge checks
2f205c4 to
4d8a15d
Compare
4d8a15d to
b75be68
Compare
706550a to
46417ce
Compare
amaskara-dd
approved these changes
Aug 20, 2024
b23fba3 to
3b6aac1
Compare
jack-edmonds-dd
approved these changes
Aug 27, 2024
ca6fd76 to
633fdf5
Compare
| "live_span": "live_span", | ||
| } | ||
|
|
||
| def __init__(self_, live_span: Union[WidgetLiveSpan, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, live_span: Union[WidgetLiveSpan, UnsetType] = unset, **kwargs): | |
| def __init__(self, live_span: Union[WidgetLiveSpan, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "value": "value", | ||
| } | ||
|
|
||
| def __init__(self_, type: WidgetNewLiveSpanType, unit: WidgetLiveSpanUnit, value: int, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, type: WidgetNewLiveSpanType, unit: WidgetLiveSpanUnit, value: int, **kwargs): | |
| def __init__(self, type: WidgetNewLiveSpanType, unit: WidgetLiveSpanUnit, value: int, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "type": "type", | ||
| } | ||
|
|
||
| def __init__(self_, _from: int, to: int, type: WidgetNewFixedSpanType, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, _from: int, to: int, type: WidgetNewFixedSpanType, **kwargs): | |
| def __init__(self, _from: int, to: int, type: WidgetNewFixedSpanType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
adc978d to
044e3e3
Compare
044e3e3 to
8d169c4
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
…an object (#2097) * add support for additional:Properties false * enable additionalProperties by default * enabled additionalProps * reduce change size * Update .generator/src/generator/templates/model_generic.j2 Co-authored-by: jack-edmonds-dd <jack.edmonds@datadoghq.com> * remove check * Regenerate client from commit 2d21d782 of spec repo --------- Co-authored-by: Anika Maskara <anika.maskara@datadoghq.com> Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com> Co-authored-by: Sherzod Karimov <sherzod.karimov@datadoghq.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: jack-edmonds-dd <jack.edmonds@datadoghq.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> e3d4aa2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#2745
Test branch datadog-api-spec/test/bruce.tu/DBNBK-116-Extend-Widget.TIME-schema