Add new synthetics HTTP javascript assertion #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b901197 to
7297e95
Compare
f734874 to
02c2672
Compare
skarimo
approved these changes
Sep 4, 2024
47d986c to
d1cda2a
Compare
| "type": "type", | ||
| } | ||
|
|
||
| def __init__(self_, code: str, type: SyntheticsAssertionJavascriptType, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, code: str, type: SyntheticsAssertionJavascriptType, **kwargs): | |
| def __init__(self, code: str, type: SyntheticsAssertionJavascriptType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
d1cda2a to
4e25bb7
Compare
3e9dfa6 to
3858cad
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> 7306432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#2962
Test branch datadog-api-spec/test/romain.guarinoni/add-js-assertion