Support paginated methods in async client #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to support both sync and async in paginated methods, we need to push the pagination logic to the client so that the coroutine handling can be handled there and the top level method retains the lower level returned type. This refactors it a bit to be able to do that.
eff75ab to
18c73a9
Compare
skarimo
approved these changes
Aug 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
* Support paginated methods in async client To be able to support both sync and async in paginated methods, we need to push the pagination logic to the client so that the coroutine handling can be handled there and the top level method retains the lower level returned type. This refactors it a bit to be able to do that. * Less duplication * Remove some more duplication * Remove specific method * Don't pass parameters that breaks data handling e3d89d9
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to support both sync and async in paginated methods, we need to push the pagination logic to the client so that the coroutine handling can be handled there and the top level method retains the lower level returned type. This refactors it a bit to be able to do that.