Remove models for arrays #1431
Merged
Remove models for arrays #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array introduces a level of indirection which doesn't bring much value. We're losing some validation but we gain consistency which I think is worth it. See #1377
skarimo
reviewed
Apr 26, 2023
skarimo
approved these changes
May 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2023
* Remove models for arrays Array introduces a level of indirection which doesn't bring much value. We're losing some validation but we gain consistency which I think is worth it. See #1377 * Fix mypy almost * Progress * Green now * Fix examples * Cleanup * Another cleanup * Fix unused models * Unless ibits * Handle Point * Fix subitem handling * Fix distribution_point_item * pre-commit fixes * Cleanup * Last fix for unparsed list? * pre-commit fixes --------- Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 74fa0a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array introduces a level of indirection which doesn't bring much value. We're losing some validation but we gain consistency which I think is worth it.
See #1377