Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Beta status for SLO history endpoint #1212

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Remove Beta status for SLO history endpoint #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.4",
"regenerated": "2022-10-25 16:38:53.561467",
"spec_repo_commit": "afdd6b70"
"regenerated": "2022-10-25 17:03:46.463169",
"spec_repo_commit": "9673a7f6"
},
"v2": {
"apigentools_version": "1.6.4",
"regenerated": "2022-10-25 16:38:53.576826",
"spec_repo_commit": "afdd6b70"
"regenerated": "2022-10-25 17:03:46.475072",
"spec_repo_commit": "9673a7f6"
}
}
}
3 changes: 0 additions & 3 deletions .generator/schemas/v1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25271,9 +25271,6 @@ paths:
summary: Get an SLO's history
tags:
- Service Level Objectives
x-unstable: '**Note**: This endpoint is in public beta.

If you have any feedback, contact [Datadog support](https://docs.datadoghq.com/help/).'
/api/v1/synthetics/ci/batch/{batch_id}:
get:
description: Get a batch's updated details.
Expand Down
1 change: 0 additions & 1 deletion examples/v1/service-level-objectives/GetSLOHistory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
SLO_DATA_0_ID = environ["SLO_DATA_0_ID"]

configuration = Configuration()
configuration.unstable_operations["get_slo_history"] = True
with ApiClient(configuration) as api_client:
api_instance = ServiceLevelObjectivesApi(api_client)
response = api_instance.get_slo_history(
Expand Down
1 change: 0 additions & 1 deletion src/datadog_api_client/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ def __init__(
# Keep track of unstable operations
self.unstable_operations = _UnstableOperations(
{
"v1.get_slo_history": False,
"v1.search_slo": False,
"v2.list_events": False,
"v2.search_events": False,
Expand Down
7 changes: 2 additions & 5 deletions tests/v1/features/service_level_objectives.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,7 @@ Feature: Service Level Objectives

@generated @skip @team:DataDog/slo-app
Scenario: Get an SLO's history returns "Bad Request" response
Given operation "GetSLOHistory" enabled
And new "GetSLOHistory" request
Given new "GetSLOHistory" request
And request contains "slo_id" parameter from "REPLACE.ME"
And request contains "from_ts" parameter from "REPLACE.ME"
And request contains "to_ts" parameter from "REPLACE.ME"
Expand All @@ -158,8 +157,7 @@ Feature: Service Level Objectives

@generated @skip @team:DataDog/slo-app
Scenario: Get an SLO's history returns "Not Found" response
Given operation "GetSLOHistory" enabled
And new "GetSLOHistory" request
Given new "GetSLOHistory" request
And request contains "slo_id" parameter from "REPLACE.ME"
And request contains "from_ts" parameter from "REPLACE.ME"
And request contains "to_ts" parameter from "REPLACE.ME"
Expand All @@ -169,7 +167,6 @@ Feature: Service Level Objectives
@team:DataDog/slo-app
Scenario: Get an SLO's history returns "OK" response
Given there is a valid "slo" in the system
And operation "GetSLOHistory" enabled
And new "GetSLOHistory" request
And request contains "slo_id" parameter from "slo.data[0].id"
And request contains "from_ts" parameter with value {{ timestamp("now - 1d") }}
Expand Down