Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable marker on security list signal endpoint #1047

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Remove unstable marker on security list signal endpoint #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.2",
"regenerated": "2022-06-14 13:57:37.537003",
"spec_repo_commit": "d8a79527"
"regenerated": "2022-06-14 14:43:12.105041",
"spec_repo_commit": "905f3e95"
},
"v2": {
"apigentools_version": "1.6.2",
"regenerated": "2022-06-14 13:57:37.550713",
"spec_repo_commit": "d8a79527"
"regenerated": "2022-06-14 14:43:12.122439",
"spec_repo_commit": "905f3e95"
}
}
}
6 changes: 0 additions & 6 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12007,9 +12007,6 @@ paths:
resultsPath: data
x-undo:
type: safe
x-unstable: '**Note**: This endpoint is in public beta.

If you have any feedback, contact [Datadog support](https://docs.datadoghq.com/help/).'
/api/v2/security_monitoring/signals/search:
post:
description: 'Returns security signals that match a search query.
Expand Down Expand Up @@ -12054,9 +12051,6 @@ paths:
resultsPath: data
x-undo:
type: safe
x-unstable: '**Note**: This endpoint is in public beta.

If you have any feedback, contact [Datadog support](https://docs.datadoghq.com/help/).'
/api/v2/series:
post:
description: "The metrics end-point allows you to post time-series data that
Expand Down
1 change: 0 additions & 1 deletion examples/v2/security-monitoring/ListSecurityMonitoringSignals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from datadog_api_client.v2.api.security_monitoring_api import SecurityMonitoringApi

configuration = Configuration()
configuration.unstable_operations["list_security_monitoring_signals"] = True
with ApiClient(configuration) as api_client:
api_instance = SecurityMonitoringApi(api_client)
response = api_instance.list_security_monitoring_signals()
Expand Down
1 change: 0 additions & 1 deletion examples/v2/security-monitoring/SearchSecurityMonitoringSignals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
)

configuration = Configuration()
configuration.unstable_operations["search_security_monitoring_signals"] = True
with ApiClient(configuration) as api_client:
api_instance = SecurityMonitoringApi(api_client)
response = api_instance.search_security_monitoring_signals(body=body)
Expand Down
2 changes: 0 additions & 2 deletions src/datadog_api_client/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,6 @@ def __init__(
"v2.get_incident": False,
"v2.list_incidents": False,
"v2.update_incident": False,
"v2.list_security_monitoring_signals": False,
"v2.search_security_monitoring_signals": False,
"v2.create_incident_service": False,
"v2.delete_incident_service": False,
"v2.get_incident_service": False,
Expand Down
18 changes: 6 additions & 12 deletions tests/v2/features/security_monitoring.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,47 +102,41 @@ Feature: Security Monitoring

@generated @skip @team:DataDog/security-monitoring
Scenario: Get a list of security signals returns "Bad Request" response
Given operation "SearchSecurityMonitoringSignals" enabled
And new "SearchSecurityMonitoringSignals" request
Given new "SearchSecurityMonitoringSignals" request
And body with value {"filter": {"from": "2019-01-02T09:42:36.320Z", "query": "security:attack status:high", "to": "2019-01-03T09:42:36.320Z"}, "page": {"cursor": "eyJzdGFydEF0IjoiQVFBQUFYS2tMS3pPbm40NGV3QUFBQUJCV0V0clRFdDZVbG8zY3pCRmNsbHJiVmxDWlEifQ==", "limit": 25}, "sort": "timestamp"}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/security-monitoring
Scenario: Get a list of security signals returns "OK" response
Given operation "SearchSecurityMonitoringSignals" enabled
And new "SearchSecurityMonitoringSignals" request
Given new "SearchSecurityMonitoringSignals" request
And body with value {"filter": {"from": "2019-01-02T09:42:36.320Z", "query": "security:attack status:high", "to": "2019-01-03T09:42:36.320Z"}, "page": {"cursor": "eyJzdGFydEF0IjoiQVFBQUFYS2tMS3pPbm40NGV3QUFBQUJCV0V0clRFdDZVbG8zY3pCRmNsbHJiVmxDWlEifQ==", "limit": 25}, "sort": "timestamp"}
When the request is sent
Then the response status is 200 OK

@replay-only @team:DataDog/security-monitoring @with-pagination
Scenario: Get a list of security signals returns "OK" response with pagination
Given operation "SearchSecurityMonitoringSignals" enabled
And new "SearchSecurityMonitoringSignals" request
Given new "SearchSecurityMonitoringSignals" request
And body with value {"filter": {"from": "{{ timeISO("now-15m") }}", "query": "security:attack status:high", "to": "{{ timeISO("now") }}"}, "page": {"limit": 2}, "sort": "timestamp"}
When the request with pagination is sent
Then the response status is 200 OK
And the response has 3 items

@generated @skip @team:DataDog/security-monitoring
Scenario: Get a quick list of security signals returns "Bad Request" response
Given operation "ListSecurityMonitoringSignals" enabled
And new "ListSecurityMonitoringSignals" request
Given new "ListSecurityMonitoringSignals" request
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/security-monitoring
Scenario: Get a quick list of security signals returns "OK" response
Given operation "ListSecurityMonitoringSignals" enabled
And new "ListSecurityMonitoringSignals" request
Given new "ListSecurityMonitoringSignals" request
When the request is sent
Then the response status is 200 OK

@replay-only @team:DataDog/security-monitoring @with-pagination
Scenario: Get a quick list of security signals returns "OK" response with pagination
Given operation "ListSecurityMonitoringSignals" enabled
And new "ListSecurityMonitoringSignals" request
Given new "ListSecurityMonitoringSignals" request
And request contains "page[limit]" parameter with value 2
When the request with pagination is sent
Then the response status is 200 OK
Expand Down