Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Test message required #803

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Browser Test message required #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13b1585
Make messsage property required
jirikuncar Mar 23, 2021
657ee6b
Merge branch 'master' into datadog-api-spec/test/sarina/browser-test-…
api-clients-generation-pipeline[bot] Mar 23, 2021
b13cd92
Merge branch 'master' into datadog-api-spec/test/sarina/browser-test-…
api-clients-generation-pipeline[bot] Mar 23, 2021
020f57e
Regenerate client from commit 34cf37f of spec repo
Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.4.1.dev6",
"regenerated": "2021-03-23 09:32:41.597034",
"spec_repo_commit": "c679afc"
"regenerated": "2021-03-23 10:51:41.342590",
"spec_repo_commit": "34cf37f"
},
"v2": {
"apigentools_version": "1.4.1.dev6",
"regenerated": "2021-03-23 09:32:49.272303",
"spec_repo_commit": "c679afc"
"regenerated": "2021-03-23 10:51:49.967652",
"spec_repo_commit": "34cf37f"
}
}
}
8 changes: 6 additions & 2 deletions api/v1/datadog/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16549,7 +16549,7 @@ components:
locations:
- locations
- locations
message: message
message: ""
type: browser
config:
request:
Expand Down Expand Up @@ -16607,7 +16607,9 @@ components:
type: string
type: array
message:
description: Notification message associated with the test.
description: Notification message associated with the test. Message can
either be text or an empty string.
example: ""
type: string
monitor_id:
description: The associated monitor ID.
Expand Down Expand Up @@ -16636,6 +16638,8 @@ components:
type: array
type:
$ref: '#/components/schemas/SyntheticsBrowserTestType'
required:
- message
type: object
SyntheticsBrowserTestConfig:
description: Configuration object for a Synthetic browser test.
Expand Down
4 changes: 2 additions & 2 deletions api/v1/datadog/docs/SyntheticsApi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ func main() {
)
}

body := *datadog.NewSyntheticsBrowserTest() // SyntheticsBrowserTest | Details of the test to create.
body := *datadog.NewSyntheticsBrowserTest("Message_example") // SyntheticsBrowserTest | Details of the test to create.

configuration := datadog.NewConfiguration()

Expand Down Expand Up @@ -2018,7 +2018,7 @@ func main() {
}

publicId := "publicId_example" // string | The public ID of the test to get details from.
body := *datadog.NewSyntheticsBrowserTest() // SyntheticsBrowserTest | New test details to be saved.
body := *datadog.NewSyntheticsBrowserTest("Message_example") // SyntheticsBrowserTest | New test details to be saved.

configuration := datadog.NewConfiguration()

Expand Down
9 changes: 2 additions & 7 deletions api/v1/datadog/docs/SyntheticsBrowserTest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**Config** | Pointer to [**SyntheticsBrowserTestConfig**](SyntheticsBrowserTestConfig.md) | | [optional]
**Locations** | Pointer to **[]string** | Array of locations used to run the test. | [optional]
**Message** | Pointer to **string** | Notification message associated with the test. | [optional]
**Message** | **string** | Notification message associated with the test. Message can either be text or an empty string. |
**MonitorId** | Pointer to **int64** | The associated monitor ID. | [optional]
**Name** | Pointer to **string** | Name of the test. | [optional]
**Options** | Pointer to [**SyntheticsTestOptions**](SyntheticsTestOptions.md) | | [optional]
Expand All @@ -20,7 +20,7 @@ Name | Type | Description | Notes

### NewSyntheticsBrowserTest

`func NewSyntheticsBrowserTest() *SyntheticsBrowserTest`
`func NewSyntheticsBrowserTest(message string, ) *SyntheticsBrowserTest`

NewSyntheticsBrowserTest instantiates a new SyntheticsBrowserTest object
This constructor will assign default values to properties that have it defined,
Expand Down Expand Up @@ -104,11 +104,6 @@ and a boolean to check if the value has been set.

SetMessage sets Message field to given value.

### HasMessage

`func (o *SyntheticsBrowserTest) HasMessage() bool`

HasMessage returns a boolean if a field has been set.

### GetMonitorId

Expand Down
35 changes: 14 additions & 21 deletions api/v1/datadog/model_synthetics_browser_test_.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/api/v1/datadog/api_synthetics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ func getTestSyntheticsBrowser(ctx context.Context, t *testing.T) datadog.Synthet
},
},
Locations: &[]string{"aws:us-east-2"},
Message: datadog.PtrString("Go client testing Synthetics Browser test - this is message"),
Message: "Go client testing Synthetics Browser test - this is message",
Name: tests.UniqueEntityName(ctx, t),
Options: &datadog.SyntheticsTestOptions{
AcceptSelfSigned: datadog.PtrBool(false),
Expand Down