Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update synthetics test to contain latest features #375

Merged
merged 10 commits into from
Jul 8, 2020
Merged

Update synthetics test to contain latest features #375

merged 10 commits into from
Jul 8, 2020

Conversation

api-clients-generation-pipeline[bot]
Copy link
Contributor

@api-clients-generation-pipeline api-clients-generation-pipeline bot requested a review from a team as a code owner July 8, 2020 07:59
@api-clients-generation-pipeline api-clients-generation-pipeline bot added the changelog/Changed Changed features results into a major version bump label Jul 8, 2020
@github-actions github-actions bot added the documentation Documentation related changes label Jul 8, 2020
@therve
Copy link
Contributor

therve commented Jul 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #375 into master will decrease coverage by 0.11%.
The diff coverage is 23.10%.

Impacted Files Coverage Δ
...el_synthetics_assertion_json_path_target_target.go 11.68% <11.68%> (ø)
...dog/model_synthetics_assertion_json_path_target.go 18.18% <18.18%> (ø)
...pi/v1/datadog/model_synthetics_assertion_target.go 18.18% <18.18%> (ø)
...g/model_synthetics_assertion_json_path_operator.go 30.00% <30.00%> (ø)
api/v1/datadog/model_synthetics_assertion.go 40.32% <55.55%> (+27.82%) ⬆️
.../v1/datadog/model_synthetics_assertion_operator.go 30.00% <100.00%> (+3.33%) ⬆️
api/v2/datadog/model_logs_list_request_page.go 0.00% <0.00%> (-25.00%) ⬇️
.../v1/datadog/model_slo_bulk_delete_response_data.go 0.00% <0.00%> (-10.00%) ⬇️
api/v2/datadog/model_logs_list_request.go 18.18% <0.00%> (-5.20%) ⬇️
api/v1/datadog/model_logs_list_response.go 5.19% <0.00%> (-3.90%) ⬇️
... and 8 more

@therve therve merged commit de22f80 into master Jul 8, 2020
@therve therve deleted the datadog-api-spec/generated/451 branch July 8, 2020 08:13
@chussenot
Copy link

@therve Thx a lot.

@chussenot
Copy link

Can we already bump this to version v1.0.0-beta.7 @therve
https://github.com/terraform-providers/terraform-provider-datadog/blob/master/go.mod

@chussenot
Copy link

chussenot commented Jul 8, 2020 •
edited
Loading

I can see some assertions issues with the master branch on the terraform provider.

# clementh @ office-laptop in /tmp/terraform-provider-datadog on git:feature/synthetics-json-assertions x [12:29:54] C:2
$ gd
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
modified: go.mod
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ go.mod:5 @ module github.com/terraform-providers/terraform-provider-datadog

require (
    4d63.com/tz v1.1.0
    github.com/DataDog/datadog-api-client-go v1.0.0-beta.6
    github.com/DataDog/datadog-api-client-go v1.0.0-beta.6.0.20200708081302-de22f80d51ca
    github.com/cenkalti/backoff v2.1.1+incompatible // indirect
    github.com/dnaeon/go-vcr v1.0.1
    github.com/hashicorp/go-cleanhttp v0.5.1
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
modified: go.sum
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ go.sum:18 @ github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
github.com/DataDog/datadog-api-client-go v1.0.0-beta.6 h1:Qo8yrEqe78Cr4xhoaQ3m1W51DzdHtOO+PBysxIJfdIc=
github.com/DataDog/datadog-api-client-go v1.0.0-beta.6/go.mod h1:ZuO6dfc8NYoBnrl4Hv093e2f4R3oxSil0/OpAblUjG8=
github.com/DataDog/datadog-api-client-go v1.0.0-beta.6.0.20200708081302-de22f80d51ca h1:NyitHiKpTETVm/Em0Kh7jl78sRIopjPfgbchhhvIbmA=
github.com/DataDog/datadog-api-client-go v1.0.0-beta.6.0.20200708081302-de22f80d51ca/go.mod h1:ZuO6dfc8NYoBnrl4Hv093e2f4R3oxSil0/OpAblUjG8=
github.com/DataDog/datadog-go v3.6.0+incompatible h1:ILg7c5Y1KvZFDOaVS0higGmJ5Fal5O1KQrkrT9j6dSM=
github.com/DataDog/datadog-go v3.6.0+incompatible/go.mod h1:LButxg5PwREeZtORoXG3tL4fMGNddJ+vMq1mwgfaqoQ=
github.com/agext/levenshtein v1.2.1/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=

# clementh @ office-laptop in /tmp/terraform-provider-datadog on git:feature/synthetics-json-assertions x [12:29:44] 
$ make
==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-datadog/datadog
datadog/resource_datadog_synthetics_test_.go:339:14: assertion.SetType undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetType)
datadog/resource_datadog_synthetics_test_.go:343:14: assertion.SetProperty undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetProperty)
datadog/resource_datadog_synthetics_test_.go:347:14: assertion.SetOperator undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetOperator)
datadog/resource_datadog_synthetics_test_.go:350:35: assertion.GetType undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method GetType)
datadog/resource_datadog_synthetics_test_.go:352:15: assertion.SetTarget undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetTarget)
datadog/resource_datadog_synthetics_test_.go:353:24: assertion.GetOperator undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method GetOperator)
datadog/resource_datadog_synthetics_test_.go:354:15: assertion.SetTarget undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetTarget)
datadog/resource_datadog_synthetics_test_.go:356:15: assertion.SetTarget undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method SetTarget)
datadog/resource_datadog_synthetics_test_.go:472:24: assertion.GetOperatorOk undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method GetOperatorOk)
datadog/resource_datadog_synthetics_test_.go:475:15: assertion.HasProperty undefined (type "github.com/DataDog/datadog-api-client-go/api/v1/datadog".SyntheticsAssertion has no field or method HasProperty)
datadog/resource_datadog_synthetics_test_.go:475:15: too many errors
note: module requires Go 1.13make: *** [GNUmakefile:12: build] Error 2

@therve
Copy link
Contributor

therve commented Jul 8, 2020

Yes I need to update the code.

sfluor pushed a commit that referenced this pull request Jul 29, 2020
@api-clients-generation-pipeline @therve @sfluor
Update synthetics test to contain latest features (#375)
7262bc4 
* Update to use new target objects

* Add new target

* Remove the integer target

* Add test showing failure

* Regenerate client from commit 44c5568 of spec repo

Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com>
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

Assignees
No one assigned
Labels
changelog/Changed Changed features results into a major version bump documentation Documentation related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therve @chussenot