Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logs Archives endpoints #323

Merged
merged 18 commits into from
Jun 4, 2020
Merged

Add Logs Archives endpoints #323

merged 18 commits into from
Jun 4, 2020

Conversation

api-clients-generation-pipeline[bot]
Copy link
Contributor

@api-clients-generation-pipeline api-clients-generation-pipeline bot commented Jun 4, 2020 •
edited by gzussa
Loading

This PR will enable generation of the public api for logs archives on the golang client.

txominpelu and others added 18 commits June 2, 2020 08:03
@txominpelu
[logs][archives] Add tests for Logs Archives
e19299a 
- Lifecycle Test: Create - Read - Update - Delete - List
- Not found Test: Validates that the API returns 404 when the archives
cannot be found
@txominpelu
[logs][archives] Purely mock based tests
2ced67e
@txominpelu
[logs][archives] Use subtests
3d41e6e
@txominpelu
[logs][archives] Use t.Helper() and proper assert
55677dd
@txominpelu
[logs][archives] No need to test deser of input
a0b2b5b
@txominpelu
[logs][archives] Use BodyString on mocks
11f669a
@txominpelu
[logs][archives] Skip tests if mode=ignore
cdce853
@txominpelu
[logs][archives] Add test for update
b6fe235
@jirikuncar
Use sub-tests
49e2bdf
@txominpelu
[logs][archives] No need to deser input
7e10501
@txominpelu
[logs][archives] Renaming and validation on List
4adfef8
@txominpelu
[logs][archives] Remove checkArchive
9d49350
@txominpelu
[logs][archives] Remove archivesAreEqual
8e29ca3
@txominpelu
[logs][archives] Change id
7c07be7
@txominpelu
Merge branch 'master' into datadog-api-spec/test/inigo.mediavilla/log…
e59fc97 
…s_archive_spec_go_client
@jirikuncar
Apply suggestions from code review
77a6c92
Merge branch 'master' into datadog-api-spec/test/inigo.mediavilla/log…
7c11642 
…s_archive_spec_go_client
Regenerate client from commit 343cf1b of spec repo
3cb7525
@api-clients-generation-pipeline api-clients-generation-pipeline bot requested a review from a team as a code owner June 4, 2020 13:37
@api-clients-generation-pipeline api-clients-generation-pipeline bot added the changelog/Added Added features results into a minor version bump label Jun 4, 2020
@github-actions github-actions bot added the documentation Documentation related changes label Jun 4, 2020
@jirikuncar
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar added changelog/Added Added features results into a minor version bump and removed changelog/Added Added features results into a minor version bump labels Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #323 into master will decrease coverage by 0.33%.
The diff coverage is 19.94%.

Impacted Files Coverage Δ
api/v2/datadog/model_logs_archive_attributes.go 0.00% <0.00%> (ø)
api/v2/datadog/model_logs_archive_definition.go 0.00% <0.00%> (ø)
api/v2/datadog/model_logs_archive_state.go 0.00% <0.00%> (ø)
api/v2/datadog/model_relationship_to_role.go 0.00% <0.00%> (ø)
...g/model_logs_archive_create_request_destination.go 8.97% <8.97%> (ø)
api/v2/datadog/model_logs_archive.go 11.62% <11.62%> (ø)
...pi/v2/datadog/model_logs_archive_create_request.go 11.62% <11.62%> (ø)
api/v2/datadog/model_logs_archives.go 11.62% <11.62%> (ø)
...og/model_logs_archive_create_request_definition.go 11.86% <11.86%> (ø)
...i/v2/datadog/model_logs_archive_destination_gcs.go 12.64% <12.64%> (ø)
... and 35 more

@jirikuncar jirikuncar merged commit 7579b0e into master Jun 4, 2020
@jirikuncar jirikuncar deleted the datadog-api-spec/generated/407 branch June 4, 2020 13:51
@gzussa gzussa changed the title Generate API for Logs Archives Add Logs Archives endpoints Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump documentation Documentation related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirikuncar @txominpelu