Fix unparsedObject early exit #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65c07ad to
248dd38
Compare
fa112e0 to
a69f4ba
Compare
therve
reviewed
Jul 28, 2023
Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com>
89aa3e6 to
12f91e6
Compare
therve
approved these changes
Aug 4, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
* fix unparsedobject early exit --------- Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> 557665e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, once we encountered an invalid field, we would place the raw object in unparsedObject and return. This fix will make sure that unmarshalling continues even though we encounter an invalid field