Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required unmarshal in models #2057

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Conversation

therve
Copy link
Contributor

@therve therve commented Jun 22, 2023

We can use the same struct just tweaking pointers.

Fixes #2055

@therve therve added the changelog/Fixed Fixed features results into a bug fix version bump label Jun 22, 2023
@therve therve requested a review from a team as a code owner June 22, 2023 12:04
@deadok22
Copy link

There's one more json.Unmarshal call we have to get rid of before we get to linear complexity. See the comments starting from this one: #2055 (comment)

therve added 3 commits June 26, 2023 15:46
We can use the same struct just tweaking pointers.
@therve therve force-pushed the therve/remove-required-unmarshal branch from 938945b to ccea5e4 Compare June 26, 2023 13:47
@therve therve merged commit bbeac6b into master Jun 26, 2023
@therve therve deleted the therve/remove-required-unmarshal branch June 26, 2023 14:19
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
* Remove required unmarshal in models

We can use the same struct just tweaking pointers.

* Unwanted change

* Rebase bbeac6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exponential complexity in JSON parsing logic
4 participants