Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded logs-agent component from API component #34890

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GustavoCaso
Copy link
Member

What does this PR do?

Remove the hardcoded dependency of Logs Agent in the main API component

Motivation

Reduce the number of hardcoded components are required to run the API component 😄

Describe how you validated your changes

Unit Tests

Possible Drawbacks / Trade-offs

Additional Notes

@GustavoCaso GustavoCaso requested review from a team as code owners March 7, 2025 14:22
@GustavoCaso GustavoCaso added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Mar 7, 2025
@github-actions github-actions bot added the medium review PR review might take time label Mar 7, 2025
Copy link

cit-pr-commenter bot commented Mar 7, 2025

Go Package Import Differences

Baseline: dc08987
Comparison: 275e49c

binaryosarchchange
serverlesslinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/api/utils
+github.com/DataDog/datadog-agent/comp/api/api/utils/stream
serverlesslinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/api/utils
+github.com/DataDog/datadog-agent/comp/api/api/utils/stream

Copy link
Member

@gh123man gh123man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some quick sanity QA to ensure stream-logs still works on the CLI 👍

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 7, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=58093186 --os-family=ubuntu

Note: This applies to commit 275e49c

Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-configuration

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 7, 2025

Uncompressed package size comparison

Comparison with ancestor dc08987c182a6375e2ad1adaf47938018c3cdaca

Size reduction summary
package diff status size ancestor threshold
datadog-iot-agent-amd64-deb -0.00MB 62.15MB 62.15MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 62.22MB 62.22MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 62.22MB 62.22MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 812.20MB 812.20MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 821.99MB 821.99MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 821.99MB 821.99MB 0.50MB
datadog-agent-arm64-deb 0.00MB 803.14MB 803.14MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 812.91MB 812.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.29MB 39.29MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.82MB 37.82MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.55MB 440.55MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.45MB 59.45MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 7, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 786.02MiB 801.8MiB 191.52MiB 202.62MiB
static_quality_gate_agent_deb_arm64 777.32MiB 793.14MiB 174.37MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 785.99MiB 801.79MiB 193.5MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 777.34MiB 793.09MiB 175.79MiB 186.44MiB
static_quality_gate_agent_suse_amd64 786.02MiB 801.81MiB 193.5MiB 205.03MiB
static_quality_gate_agent_suse_arm64 777.4MiB 793.14MiB 175.79MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.54MiB 47.67MiB 9.73MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.14MiB 46.27MiB 8.44MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.54MiB 47.67MiB 9.74MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.54MiB 47.67MiB 9.74MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.34MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.7MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.35MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.7MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.35MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_docker_agent_amd64 870.72MiB 886.12MiB 292.88MiB 304.21MiB
static_quality_gate_docker_agent_arm64 885.34MiB 900.79MiB 279.19MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.04GiB 1.06GiB 368.0MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 350.28MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.69MiB 55.78MiB 17.23MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.32MiB 54.45MiB 16.11MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.8MiB 274.78MiB 106.27MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.73MiB 290.82MiB 101.08MiB 111.12MiB

@vickenty vickenty removed the request for review from a team March 7, 2025 15:32
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fd9ae3ac-bcc8-4e23-9e1c-a9c3bc662603

Baseline: dc08987
Comparison: 275e49c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +1.72 [+1.55, +1.89] 1 Logs
quality_gate_idle memory utilization +0.45 [+0.37, +0.52] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.44 [+0.33, +0.55] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.30 [-0.47, +1.07] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.44, +0.49] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.70, +0.70] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.85, +0.83] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.86, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.81, +0.72] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.84, +0.73] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.69 [-1.57, +0.20] 1 Logs
quality_gate_logs % cpu utilization -1.08 [-3.80, +1.63] 1 Logs
quality_gate_idle_all_features memory utilization -3.55 [-3.65, -3.45] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@NouemanKHAL NouemanKHAL removed the request for review from a team March 7, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants