Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: hostgpu payload: filter out hosts with no GPUs #34790

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

val06
Copy link
Contributor

@val06 val06 commented Mar 5, 2025

What does this PR do?

  • return nil hostgpu Payload when host doesn't have any GPU devices
  • inventory_payload: don't send nil payloads to the backend
  • added UTs to cover the nil payload case

Motivation

  • avoid sending not useful payloads to the backend when hosts don't have any (supported) GPU devices

Describe how you validated your changes

added UTs both for hostgpu and generic inventory_payload to test nil payload use case

Possible Drawbacks / Trade-offs

Additional Notes

- inventory_payload.go: don't send nil payloads to the backend
- added UTs to cover the nil payload case
@val06 val06 added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Mar 5, 2025
@val06 val06 requested review from a team as code owners March 5, 2025 16:55
@val06 val06 requested a review from dustmop March 5, 2025 16:55
@github-actions github-actions bot added the medium review PR review might take time label Mar 5, 2025
@val06 val06 added the ask-review Ask required teams to review this PR label Mar 5, 2025
Copy link
Member

@hush-hush hush-hush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attend a quick comment but looks good

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor f4d1c927e94c7fded9807a5b95d640fdbdeaaa59

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 815.48MB 815.48MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 825.28MB 825.27MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 825.28MB 825.27MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.81MB 440.81MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.44MB 59.44MB 0.50MB
datadog-agent-arm64-deb 0.00MB 806.42MB 806.42MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 816.20MB 816.20MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.44MB 39.44MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.97MB 37.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.14MB 62.14MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.21MB 62.21MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.21MB 62.21MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57823391 --os-family=ubuntu

Note: This applies to commit 98a6961

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 789.19MiB 801.8MiB 192.33MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.44MiB 793.14MiB 174.69MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 789.18MiB 801.79MiB 194.41MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.5MiB 793.09MiB 175.85MiB 186.44MiB
static_quality_gate_agent_suse_amd64 789.18MiB 801.81MiB 194.41MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.53MiB 793.14MiB 175.85MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.68MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.29MiB 46.27MiB 8.49MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.34MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.7MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.34MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.7MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.34MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.85MiB 886.12MiB 293.99MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.47MiB 900.79MiB 280.21MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.09MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.3MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.83MiB 55.78MiB 17.29MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.48MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 265.03MiB 274.78MiB 106.38MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.99MiB 290.82MiB 101.22MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4ea9b9d4-bef6-4c48-88e9-14e413c779be

Baseline: f4d1c92
Comparison: 98a6961
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.13 [+1.05, +1.21] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.49 [-0.46, +1.45] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.14 [-0.33, +0.61] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.67, +0.91] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.72, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.75, +0.84] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.76, +0.79] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.68, +0.68] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.86, +0.82] 1 Logs
quality_gate_idle memory utilization -0.06 [-0.10, -0.02] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.16 [-0.19, -0.13] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.27 [-3.11, +2.56] 1 Logs
file_tree memory utilization -0.32 [-0.38, -0.26] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@hush-hush hush-hush removed the request for review from dustmop March 6, 2025 14:45
@hush-hush
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 6, 2025

View all feedbacks in Devflow UI.
2025-03-06 15:32:43 UTC ℹ️ Start processing command /merge


2025-03-06 15:32:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.


2025-03-06 16:02:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c0121d2 into main Mar 6, 2025
236 checks passed
@dd-mergequeue dd-mergequeue bot deleted the valeri.pliskin/drop-nongpu-hosts-payloads branch March 6, 2025 16:02
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 6, 2025
github-actions bot pushed a commit to dd-bryce/not-the-agent that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants