Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-322] Upgrade otel version to 0.121.0 in Agent #34741

Merged
merged 11 commits into from
Mar 5, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Mar 4, 2025

What does this PR do?

Upgrade otel version to 0.121.0 in Agent

Motivation

routine otel dependency updates

Describe how you validated your changes

existing e2e + unit tests

@songy23 songy23 added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent labels Mar 4, 2025
@songy23 songy23 added this to the 7.65.0 milestone Mar 4, 2025
@songy23 songy23 requested review from a team as code owners March 4, 2025 16:39
@songy23 songy23 requested review from ankitpatel96 and ogaca-dd March 4, 2025 16:39
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Mar 4, 2025
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note: test/otel/testdata/ocb_build_script.sh might fail.

@songy23 songy23 removed the request for review from ankitpatel96 March 4, 2025 17:08
Copy link

cit-pr-commenter bot commented Mar 4, 2025

Go Package Import Differences

Baseline: 0ad715c
Comparison: a943fd5

binaryosarchchange
agentlinuxamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
agentlinuxarm64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
agentwindowsamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
agentdarwinamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
agentdarwinarm64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
iot-agentlinuxamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
iot-agentlinuxarm64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
heroku-agentlinuxamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
cluster-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
cluster-agentlinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
dogstatsdlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
dogstatsdlinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
process-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
process-agentlinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
process-agentwindowsamd64
+1, -0
+github.com/klauspost/compress/internal/le
process-agentdarwinamd64
+1, -0
+github.com/klauspost/compress/internal/le
process-agentdarwinarm64
+1, -0
+github.com/klauspost/compress/internal/le
heroku-process-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
security-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
security-agentlinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
security-agentwindowsamd64
+1, -0
+github.com/klauspost/compress/internal/le
serverlesslinuxamd64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
serverlesslinuxarm64
+5, -1
+github.com/klauspost/compress/internal/le
+go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer
-go.opentelemetry.io/collector/extension/auth
+go.opentelemetry.io/collector/extension/extensionauth
+go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/service/hostcapabilities
system-probelinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
system-probelinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
system-probewindowsamd64
+1, -0
+github.com/klauspost/compress/internal/le
trace-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le
trace-agentlinuxarm64
+1, -0
+github.com/klauspost/compress/internal/le
trace-agentwindowsamd64
+1, -0
+github.com/klauspost/compress/internal/le
trace-agentdarwinamd64
+1, -0
+github.com/klauspost/compress/internal/le
trace-agentdarwinarm64
+1, -0
+github.com/klauspost/compress/internal/le
heroku-trace-agentlinuxamd64
+1, -0
+github.com/klauspost/compress/internal/le

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 4, 2025

Uncompressed package size comparison

Comparison with ancestor 0ad715c59d14da78787af7283fdf39c5c6c735a5

Size reduction summary
package diff status size ancestor threshold
datadog-agent-aarch64-rpm -0.00MB 816.18MB 816.19MB 0.50MB
datadog-agent-arm64-deb -0.01MB 806.41MB 806.41MB 0.50MB
datadog-iot-agent-amd64-deb -0.01MB 62.13MB 62.14MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.01MB 62.20MB 62.21MB 0.50MB
datadog-iot-agent-x86_64-suse -0.01MB 62.20MB 62.21MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.01MB 59.43MB 59.44MB 0.50MB
datadog-iot-agent-arm64-deb -0.01MB 59.36MB 59.37MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.06MB ⚠️ 825.32MB 825.26MB 0.50MB
datadog-agent-x86_64-suse 0.06MB ⚠️ 825.32MB 825.26MB 0.50MB
datadog-agent-amd64-deb 0.06MB ⚠️ 815.53MB 815.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.05MB ⚠️ 440.86MB 440.81MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.03MB ⚠️ 39.54MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.03MB ⚠️ 39.54MB 39.51MB 0.50MB
datadog-dogstatsd-amd64-deb 0.03MB ⚠️ 39.46MB 39.44MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 37.99MB 37.97MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Mar 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 786bca67-a16c-4e89-af4f-a5cbb226c94e

Baseline: 0ad715c
Comparison: a943fd5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.35 [+0.28, +0.41] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.27 [+0.21, +0.34] 1 Logs
quality_gate_logs % cpu utilization +0.12 [-2.77, +3.02] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.06 [-0.41, +0.52] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.77, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.76, +0.81] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.69, +0.72] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.79, +0.77] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.31, +0.29] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.80, +0.75] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.85, +0.74] 1 Logs
quality_gate_idle_all_features memory utilization -0.27 [-0.30, -0.23] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.41 [-0.46, -0.36] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.34 [-2.23, -0.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@songy23 songy23 requested a review from a team as a code owner March 4, 2025 19:34
@songy23

This comment was marked as resolved.

Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for agent-apm!

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 4, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57789845 --os-family=ubuntu

Note: This applies to commit a943fd5

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 4, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 789.26MiB 801.8MiB 192.28MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.51MiB 793.14MiB 173.92MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 789.25MiB 801.79MiB 194.4MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.51MiB 793.09MiB 175.8MiB 186.44MiB
static_quality_gate_agent_suse_amd64 789.25MiB 801.81MiB 194.4MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.39MiB 793.14MiB 175.8MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.71MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.3MiB 46.27MiB 8.48MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.71MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.71MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.33MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.68MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.33MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.69MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.33MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.9MiB 886.12MiB 294.0MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.46MiB 900.79MiB 280.18MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.1MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.28MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.86MiB 55.78MiB 17.3MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.47MiB 54.45MiB 16.17MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 265.08MiB 274.78MiB 106.4MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 281.0MiB 290.82MiB 101.22MiB 111.12MiB

Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for fleet-owned files

@songy23
Copy link
Member Author

songy23 commented Mar 5, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 5, 2025

View all feedbacks in Devflow UI.
2025-03-05 16:13:30 UTC ℹ️ Start processing command /merge


2025-03-05 16:13:34 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-03-05 16:58:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 0e7e4d3 into main Mar 5, 2025
443 of 445 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTAGENT-322 branch March 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants