Backport 34556 to 7.64.x

[grantseltzer]

What does this PR do?

Backports #34556 for 7.64.x.

Motivation

This contains performance optimizations that are meant to address incident-35560

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 57564035 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 6205bcf815e98e57d6d7d4125fe4f43f9812e12d

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.14MB	⚠️	878.93MB	878.79MB	0.50MB
datadog-agent-x86_64-suse	0.14MB	⚠️	878.93MB	878.79MB	0.50MB
datadog-agent-aarch64-rpm	0.13MB	⚠️	868.21MB	868.09MB	0.50MB
datadog-agent-amd64-deb	0.11MB	⚠️	869.13MB	869.02MB	0.50MB
datadog-agent-arm64-deb	0.10MB	⚠️	858.44MB	858.34MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.34MB	59.33MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.26MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	446.34MB	446.34MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.48MB	41.48MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.48MB	41.48MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.40MB	41.40MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.66MB	39.66MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.02MB	62.02MB	0.50MB

Decision

⚠️ Warning

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57564035 --os-family=ubuntu

Note: This applies to commit b4b2461

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	840.64MiB	847.49MiB	203.04MiB	212.33MiB
✅	static_quality_gate_agent_deb_arm64	830.52MiB	836.66MiB	183.44MiB	192.5MiB
✅	static_quality_gate_agent_rpm_amd64	840.72MiB	847.82MiB	205.96MiB	215.76MiB
✅	static_quality_gate_agent_rpm_arm64	830.55MiB	836.66MiB	185.36MiB	194.24MiB
✅	static_quality_gate_agent_suse_amd64	840.77MiB	847.82MiB	205.96MiB	215.76MiB
✅	static_quality_gate_agent_suse_arm64	830.52MiB	836.66MiB	185.36MiB	194.24MiB
✅	static_quality_gate_dogstatsd_deb_amd64	39.56MiB	49.7MiB	10.55MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	37.9MiB	48.1MiB	9.12MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	39.56MiB	49.7MiB	10.56MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	39.56MiB	49.7MiB	10.56MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.6MiB	66.4MiB	12.86MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	925.02MiB	931.7MiB	309.11MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	938.08MiB	944.08MiB	294.1MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.1GiB	1.1GiB	384.19MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.1GiB	1.1GiB	365.19MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.7MiB	57.88MiB	18.26MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.09MiB	56.27MiB	17.02MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.95MiB	274.78MiB	106.34MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.93MiB	290.82MiB	101.18MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b6b0384c-ed2d-4857-99e3-cdae59c398e5

Baseline: 6c84d65
Comparison: b4b2461
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.96	[+0.90, +1.03]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.52	[-0.35, +1.38]	1	Logs
➖	file_tree	memory utilization	+0.47	[+0.41, +0.52]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.34	[-0.43, +1.12]	1	Logs
➖	quality_gate_idle	memory utilization	+0.28	[+0.24, +0.31]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.20	[-0.26, +0.66]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.06	[-0.73, +0.85]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.01	[-0.04, +0.06]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.76, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.74, +0.74]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.00	[-0.78, +0.78]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.63, +0.62]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.03, +0.02]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.29, +0.27]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.99	[-3.92, +1.95]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.