Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed Sender Draft #34648

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Distributed Sender Draft #34648

wants to merge 4 commits into from
+1,210 −332

Conversation

ddrthall
Copy link
Contributor

@ddrthall ddrthall commented Mar 3, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added long review PR is complex, plan time to review it team/agent-log-pipelines labels Mar 3, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 3, 2025 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57999227 --os-family=ubuntu

Note: This applies to commit 522a8d8

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 3, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 369a8dbb39dc6e8601d82c8f43caaaf88d6a0a55

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.14MB ⚠️ 815.54MB 815.40MB 0.50MB
datadog-agent-arm64-deb 0.14MB ⚠️ 806.50MB 806.36MB 0.50MB
datadog-agent-x86_64-rpm 0.14MB ⚠️ 825.33MB 825.19MB 0.50MB
datadog-agent-x86_64-suse 0.14MB ⚠️ 825.33MB 825.19MB 0.50MB
datadog-agent-aarch64-rpm 0.14MB ⚠️ 816.28MB 816.14MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.09MB ⚠️ 39.60MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.09MB ⚠️ 39.60MB 39.51MB 0.50MB
datadog-dogstatsd-amd64-deb 0.09MB ⚠️ 39.53MB 39.43MB 0.50MB
datadog-dogstatsd-arm64-deb 0.09MB ⚠️ 38.06MB 37.97MB 0.50MB
datadog-heroku-agent-amd64-deb 0.03MB ⚠️ 440.72MB 440.69MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 62.12MB 62.11MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 59.36MB 59.35MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 62.19MB 62.18MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 62.19MB 62.18MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 59.43MB 59.42MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 3, 2025 •
edited
Loading

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 788.77MiB 801.8MiB 192.33MiB 202.62MiB
✅ static_quality_gate_agent_deb_arm64 780.13MiB 793.14MiB 174.96MiB 184.51MiB
✅ static_quality_gate_agent_rpm_amd64 788.76MiB 801.79MiB 194.4MiB 205.03MiB
✅ static_quality_gate_agent_rpm_arm64 780.12MiB 793.09MiB 175.83MiB 186.44MiB
✅ static_quality_gate_agent_suse_amd64 788.76MiB 801.81MiB 194.4MiB 205.03MiB
✅ static_quality_gate_agent_suse_arm64 780.12MiB 793.14MiB 175.83MiB 186.44MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.77MiB 47.67MiB 9.81MiB 19.78MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.38MiB 46.27MiB 8.51MiB 18.49MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.77MiB 47.67MiB 9.82MiB 19.79MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.77MiB 47.67MiB 9.82MiB 19.79MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.32MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.68MiB 66.4MiB 12.84MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.32MiB 69.0MiB 14.92MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.68MiB 66.4MiB 12.87MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.32MiB 69.0MiB 14.92MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 873.9MiB 886.12MiB 293.98MiB 304.21MiB
✅ static_quality_gate_docker_agent_arm64 888.55MiB 900.79MiB 280.23MiB 290.47MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.08MiB 379.33MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.33MiB 361.55MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.92MiB 55.78MiB 17.32MiB 27.28MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.56MiB 54.45MiB 16.2MiB 26.16MiB
✅ static_quality_gate_docker_cluster_agent_amd64 265.02MiB 274.78MiB 106.37MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.98MiB 290.82MiB 101.21MiB 111.12MiB

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Mar 3, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4b2f2e81-e195-4553-90ba-8f90b54a0ea7

Baseline: 369a8db
Comparison: 522a8d8
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ file_to_blackhole_1000ms_latency_linear_load egress throughput +622.12 [+620.71, +623.52] 1 Logs
✅ file_to_blackhole_100ms_latency_multifile egress throughput +118.77 [+118.09, +119.44] 1 Logs
✅ file_to_blackhole_1000ms_latency egress throughput +46.02 [+45.05, +46.99] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
✅ file_to_blackhole_1000ms_latency_linear_load egress throughput +622.12 [+620.71, +623.52] 1 Logs
✅ file_to_blackhole_100ms_latency_multifile egress throughput +118.77 [+118.09, +119.44] 1 Logs
✅ file_to_blackhole_1000ms_latency egress throughput +46.02 [+45.05, +46.99] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +1.43 [+0.62, +2.25] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +1.06 [+1.00, +1.13] 1 Logs
➖ file_to_blackhole_100ms_latency_linear_load egress throughput +1.02 [+0.51, +1.52] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.77 [-0.12, +1.67] 1 Logs
➖ file_tree memory utilization +0.44 [+0.38, +0.50] 1 Logs
➖ quality_gate_idle memory utilization +0.21 [+0.18, +0.24] 1 Logs bounds checks dashboard
➖ file_to_blackhole_300ms_latency egress throughput +0.06 [-0.70, +0.81] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.31] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.75, +0.76] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.72, +0.73] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.83, +0.79] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.79, +0.73] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.49 [-0.54, -0.43] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -1.23 [-4.19, +1.74] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency_multifile memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Mar 3, 2025 •
edited
Loading

Go Package Import Differences

Baseline: 369a8db
Comparison: 522a8d8

binaryosarchchange
dogstatsdlinuxamd64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
dogstatsdlinuxarm64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
process-agentlinuxamd64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
process-agentlinuxarm64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
process-agentwindowsamd64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
process-agentdarwinamd64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
process-agentdarwinarm64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy
heroku-process-agentlinuxamd64
+4, -0 
+github.com/DataDog/datadog-agent/pkg/logs/client/tcp
+github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface
+golang.org/x/net/internal/socks
+golang.org/x/net/proxy

@ddrthall ddrthall force-pushed the ryan.hall/merged-sender-updates branch from c4d5fb3 to 3d741df Compare March 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/system-probe long review PR is complex, plan time to review it team/agent-log-pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ddrthall