[AGENTRUN-162] Disable X25519Kyber768Draft00 in the agent

[pgimalac]

What does this PR do?

Fix #34323.

#34481 added the godebug directive to disable tlskyber experiment by default, however it seems due to using a go.work the directive in the go.mod was ignored...
Some local testing indicates that setting the directive in the go.work works as expected.

Motivation

Fix issues with AWS Network Firewall.

Describe how you validated your changes

I don't have a setup with AWS Network Firewall at hand so I used a custom version of Go to check whether the GODEBUG directive was considered.

I also tried using delve, installing the agent, downloading debug symbols, setting up delve config to indicate the location of debug symbols, and finally attaching to the running agent to see the set of algorithms used.

dlv attach `pgrep -f '/opt/datadog-agent/bin/agent/agent run'`

Here are the delve instructions:

(dlv) break tlscommonend crypto/tls/common.go:114
(dlv) continue
(dlv) p curvePreferences

With 7.63.2:

(dlv) p curvePreferences
[]crypto/tls.CurveID len: 5, cap: 5, [x25519Kyber768Draft00 (25497),X25519 (29),CurveP256 (23),CurveP384 (24),CurveP521 (25)]

With 7.63.3~rc.1:

(dlv) p curvePreferences
[]crypto/tls.CurveID len: 4, cap: 4, [X25519 (29),CurveP256 (23),CurveP384 (24),CurveP521 (25)]

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 0b4f8a74c142d670fda5d6cb5a7ee1f514ac2997

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	815.30MB	815.30MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	825.10MB	825.10MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	825.10MB	825.10MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	816.05MB	816.05MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.51MB	39.51MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.51MB	39.51MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.18MB	62.18MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.18MB	62.18MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.42MB	59.42MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	806.28MB	806.28MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.43MB	39.43MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.97MB	37.97MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	440.69MB	440.69MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.11MB	62.11MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.35MB	59.35MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	788.91MiB	801.8MiB	192.26MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	780.41MiB	793.14MiB	174.32MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	788.91MiB	801.79MiB	194.33MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	780.39MiB	793.09MiB	175.81MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	788.92MiB	801.81MiB	194.33MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	780.3MiB	793.14MiB	175.81MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.68MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.29MiB	46.27MiB	8.49MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.68MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.68MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.31MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.67MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.31MiB	69.0MiB	14.92MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.67MiB	66.4MiB	12.87MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.31MiB	69.0MiB	14.92MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	873.68MiB	886.12MiB	293.9MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	888.34MiB	900.79MiB	280.15MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.01MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.21MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.83MiB	55.78MiB	17.29MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.47MiB	54.45MiB	16.17MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	265.01MiB	274.78MiB	106.36MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.97MiB	290.82MiB	101.2MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e0f2bc3e-c30c-4cbf-9791-27b546caf37a

Baseline: 0b4f8a7
Comparison: 1d27d53
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+0.25	[+0.19, +0.31]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.25	[+0.20, +0.30]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.16	[+0.10, +0.22]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.13	[-0.66, +0.92]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.04	[-2.83, +2.91]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.67, +0.69]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.82, +0.84]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.00	[-0.79, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.86, +0.86]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.63, +0.62]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.29, +0.27]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.36	[-0.83, +0.12]	1	Logs
➖	quality_gate_idle	memory utilization	-0.40	[-0.43, -0.36]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.56	[-1.34, +0.21]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-2.16	[-3.11, -1.22]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[pgimalac]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-03-04 14:56:36 UTC ℹ️ Start processing command /merge

---

2025-03-04 14:56:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

---

2025-03-04 15:39:39 UTC ℹ️ MergeQueue: This merge request was merged