Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update remote config channel #34558

Merged
merged 2 commits into from
Mar 4, 2025
Merged

update remote config channel #34558

merged 2 commits into from
Mar 4, 2025

Conversation

sabrina-datadog
Copy link
Contributor

What does this PR do?

Previously, release message notifications were sent to #remote-config-monitoring, however it is a really noisy so switching to #remote-config-platform for better visibility

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@sabrina-datadog sabrina-datadog added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 28, 2025
@sabrina-datadog sabrina-datadog requested review from a team as code owners February 28, 2025 03:45
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 28, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor c99883d062e9593674298c57d3d9205c93935130

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 815.40MB 815.40MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 825.19MB 825.19MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 825.19MB 825.19MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 806.36MB 806.36MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 816.14MB 816.14MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 39.43MB 39.43MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 37.97MB 37.97MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 440.69MB 440.69MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.11MB 62.11MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.18MB 62.18MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.18MB 62.18MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.35MB 59.35MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.42MB 59.42MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 28, 2025 •
edited
Loading

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 789.14MiB 801.8MiB 192.29MiB 202.62MiB
✅ static_quality_gate_agent_deb_arm64 780.47MiB 793.14MiB 174.62MiB 184.51MiB
✅ static_quality_gate_agent_rpm_amd64 789.0MiB 801.79MiB 194.34MiB 205.03MiB
✅ static_quality_gate_agent_rpm_arm64 780.36MiB 793.09MiB 175.83MiB 186.44MiB
✅ static_quality_gate_agent_suse_amd64 789.11MiB 801.81MiB 194.34MiB 205.03MiB
✅ static_quality_gate_agent_suse_arm64 780.47MiB 793.14MiB 175.83MiB 186.44MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.68MiB 47.67MiB 9.78MiB 19.78MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.29MiB 46.27MiB 8.49MiB 18.49MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.31MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.67MiB 66.4MiB 12.86MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.31MiB 69.0MiB 14.92MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.67MiB 66.4MiB 12.86MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.31MiB 69.0MiB 14.92MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 873.77MiB 886.12MiB 293.92MiB 304.21MiB
✅ static_quality_gate_docker_agent_arm64 888.42MiB 900.79MiB 280.18MiB 290.47MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.03MiB 379.33MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.24MiB 361.55MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.83MiB 55.78MiB 17.29MiB 27.28MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.47MiB 54.45MiB 16.17MiB 26.16MiB
✅ static_quality_gate_docker_cluster_agent_amd64 265.01MiB 274.78MiB 106.38MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.97MiB 290.82MiB 101.21MiB 111.12MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 28, 2025 •
edited
Loading

[Fast Unit Tests Report]

On pipeline 57524183 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Feb 28, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4a132f21-93ba-4cd8-bfd9-7824bb3108c7

Baseline: c99883d
Comparison: 6bac495
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +3.69 [+0.67, +6.70] 1 Logs
➖ quality_gate_idle memory utilization +0.61 [+0.58, +0.65] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.57 [+0.52, +0.62] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.38 [-0.53, +1.28] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.08 [-0.70, +0.86] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.83, +0.93] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.03 [-0.68, +0.73] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.30] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.77, +0.76] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.61] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.02 [-0.80, +0.77] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.14 [-0.92, +0.63] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.39 [-0.85, +0.07] 1 Logs
➖ file_tree memory utilization -0.66 [-0.73, -0.59] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -2.38 [-2.47, -2.29] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@sabrina-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 4, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-04 01:39:42 UTC ℹ️ Start processing command /merge

2025-03-04 01:39:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 32m.

2025-03-04 02:06:48 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 93228cc into main Mar 4, 2025
216 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sabrina/update-github-map branch March 4, 2025 02:06
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 4, 2025
@iliakur iliakur mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelianR CelianR CelianR approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Milestone
7.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sabrina-datadog @CelianR