Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for static KSM tags #34557

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

justin-lesko
Copy link
Contributor

@justin-lesko justin-lesko commented Feb 27, 2025

What does this PR do?

This PR adds checks for static tags from the DD_TAGS environment variable and kubernetes_state_core.yaml instance config.

Motivation

Testing for static tag regression.

Describe how you validated your changes

I invoked the KSM test suite locally:

deva new-e2e-tests.run --targets ./tests/containers --run TestKindSuite/TestKSM --cluster-agent-image docker.io/datadog/cluster-agent:7.64.0-rc.4 --agent-image docker.io/datadog/agent:7.64.0-rc.4


=== RUN   TestKindSuite/TestKSM
    base_test.go:37: START  kindSuite/TestKSM 2025-02-26 17:03:39.034871 -0500 EST m=+275.138871043
=== RUN   TestKindSuite/TestKSM/metric___kubernetes_state.vpa.count{^kube_namespace:workload-nginx$}
=== RUN   TestKindSuite/TestKSM/metric___kubernetes_state.vpa.count{^kube_namespace:workload-redis$}
=== RUN   TestKindSuite/TestKSM/metric___kubernetes_state_customresource.ddm_value{}

Possible Drawbacks / Trade-offs

Additional Notes

Related PR: DataDog/test-infra-definitions#1443

@justin-lesko justin-lesko added the qa/done QA done before merge and regressions are covered by tests label Feb 27, 2025
@justin-lesko
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

@dd-devflow
Copy link

dd-devflow bot commented Feb 27, 2025

View all feedbacks in Devflow UI.
2025-02-27 22:05:25 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto


2025-02-27 22:06:04 UTC ℹ️ Gitlab pipeline started

Started pipeline #57284048

@dd-devflow
Copy link

dd-devflow bot commented Feb 27, 2025

View all feedbacks in Devflow UI.
2025-02-27 22:06:06 UTC ℹ️ Devflow: /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

@justin-lesko justin-lesko marked this pull request as ready for review February 27, 2025 22:19
@justin-lesko justin-lesko requested review from a team as code owners February 27, 2025 22:19
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

[Fast Unit Tests Report]

On pipeline 58172172 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@justin-lesko justin-lesko changed the title Justin/contint 3668 add e2e tests for static tags Add e2e tests for static KSM tags Feb 27, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=58172172 --os-family=ubuntu

Note: This applies to commit 0794f9e

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

Uncompressed package size comparison

Comparison with ancestor eb6d35ef1b3a2fee6dfdebbaa1fbce23751a4c87

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 811.33MB 811.33MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 821.12MB 821.12MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 821.12MB 821.12MB 0.50MB
datadog-agent-arm64-deb 0.00MB 802.31MB 802.31MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 812.08MB 812.08MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.29MB 39.29MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.82MB 37.82MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.53MB 440.53MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.13MB 62.13MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.20MB 62.20MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.20MB 62.20MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.35MB 59.35MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.42MB 59.42MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 785.1 MiB 801.8 MiB 191.44 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 776.47 MiB 793.14 MiB 173.11 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 785.22 MiB 801.79 MiB 193.13 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 776.62 MiB 793.09 MiB 175.63 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 785.15 MiB 801.81 MiB 193.13 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 776.49 MiB 793.14 MiB 175.63 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.54 MiB 47.67 MiB 9.73 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.14 MiB 46.27 MiB 8.44 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.54 MiB 47.67 MiB 9.74 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.54 MiB 47.67 MiB 9.74 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 59.33 MiB 69.0 MiB 14.9 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 56.68 MiB 66.4 MiB 12.87 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 59.33 MiB 69.0 MiB 14.92 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 56.68 MiB 66.4 MiB 12.86 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 59.33 MiB 69.0 MiB 14.92 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 869.89 MiB 886.12 MiB 292.65 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 884.55 MiB 900.79 MiB 278.95 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 367.75 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.05 GiB 1.06 GiB 350.01 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.69 MiB 55.78 MiB 17.23 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.33 MiB 54.45 MiB 16.11 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 264.82 MiB 274.78 MiB 106.28 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 280.75 MiB 290.82 MiB 101.1 MiB 111.12 MiB

Copy link

cit-pr-commenter bot commented Feb 27, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 97b0bcce-278a-430b-9bdc-a49a3b061a23

Baseline: eb6d35e
Comparison: 0794f9e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +3.83 [+3.64, +4.02] 1 Logs
quality_gate_logs % cpu utilization +0.88 [-1.88, +3.63] 1 Logs
quality_gate_idle memory utilization +0.55 [+0.46, +0.65] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.42 [+0.30, +0.55] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.37 [-0.40, +1.14] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.38, +0.55] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.78, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.80, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.30, +0.32] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.66, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.83, +0.79] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.84, +0.72] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.55 [-1.40, +0.29] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.88 [-0.94, -0.82] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@justin-lesko justin-lesko requested a review from jennchenn March 7, 2025 21:42
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Mar 7, 2025
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-devx-infra team/agent-devx-loops team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants