Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMS: GPU entity fixes #34490

Merged
merged 2 commits into from
Feb 27, 2025
Merged

WMS: GPU entity fixes #34490

merged 2 commits into from
Feb 27, 2025

Conversation

val06
Copy link
Contributor

@val06 val06 commented Feb 26, 2025

What does this PR do?

This PR fixes GPUEntity collection:

  • removed SMCount (the previously used GetAttributes nvml API is available only for MIG devices)
  • instead added TotalCores via GetNumCores API (SMCount can be calculated using pre-defined table of device architecture to number of cores for SM)
  • changed TotalMemory retrieval to use a different nvml API (also used GetAttributes API)

Motivation

Wider support for GPU devices data

Describe how you validated your changes

Updated nvml mocks and UTs to test the new fields

Possible Drawbacks / Trade-offs

Additional Notes

@val06
covered new added fields with UTs
f3e5ccb 
removed SMCount (the API is available only for MIG devices)
added TotalCores instead
changed TotalMemory compute to use a different nvml API that is available for all devices
@val06 val06 added team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Feb 26, 2025
@val06 val06 requested review from a team as code owners February 26, 2025 17:41
@github-actions github-actions bot added the medium review PR review might take time label Feb 26, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor e3dc9b4580ef0d221a536a0fde89d39203ccf02f

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.06MB 62.05MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.13MB 62.12MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.13MB 62.12MB 0.50MB
datadog-agent-amd64-deb 0.00MB ✅ 818.00MB 818.00MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 827.79MB 827.79MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 827.79MB 827.79MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 808.97MB 808.97MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 818.74MB 818.74MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 443.42MB 443.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.29MB 59.29MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.36MB 59.36MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57088704 --os-family=ubuntu

Note: This applies to commit 5161d96

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 791.89MiB 801.8MiB 192.65MiB 202.62MiB
✅ static_quality_gate_agent_deb_arm64 783.25MiB 793.14MiB 174.16MiB 184.51MiB
✅ static_quality_gate_agent_rpm_amd64 791.88MiB 801.79MiB 195.03MiB 205.03MiB
✅ static_quality_gate_agent_rpm_arm64 783.17MiB 793.09MiB 176.34MiB 186.44MiB
✅ static_quality_gate_agent_suse_amd64 791.81MiB 801.81MiB 195.03MiB 205.03MiB
✅ static_quality_gate_agent_suse_arm64 783.19MiB 793.14MiB 176.34MiB 186.44MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.28MiB 46.27MiB 8.49MiB 18.49MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.26MiB 69.0MiB 14.89MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.62MiB 66.4MiB 12.84MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.26MiB 69.0MiB 14.91MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.62MiB 66.4MiB 12.85MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.26MiB 69.0MiB 14.91MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 876.25MiB 886.12MiB 294.27MiB 304.21MiB
✅ static_quality_gate_docker_agent_arm64 890.9MiB 900.79MiB 280.53MiB 290.47MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.36MiB 379.33MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.59MiB 361.55MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.82MiB 55.78MiB 17.28MiB 27.28MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.45MiB 16.16MiB 26.16MiB
✅ static_quality_gate_docker_cluster_agent_amd64 264.96MiB 274.78MiB 106.34MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.93MiB 290.82MiB 101.18MiB 111.12MiB

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: afa8e996-8478-4753-9056-07cf599e879a

Baseline: e3dc9b4
Comparison: 5161d96
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +0.34 [-2.53, +3.22] 1 Logs
➖ file_tree memory utilization +0.20 [+0.15, +0.26] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.13 [-0.66, +0.92] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.13 [-0.34, +0.60] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.83, +0.86] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.83, +0.84] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.28] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.80, +0.80] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.84, +0.71] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.17 [-0.25, -0.09] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.53 [-0.58, -0.48] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.63 [-0.68, -0.59] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -2.28 [-3.14, -1.43] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@val06 val06 added the ask-review Ask required teams to review this PR label Feb 27, 2025
@val06
Copy link
Contributor Author

val06 commented Feb 27, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-27 09:42:32 UTC ℹ️ Start processing command /merge

2025-02-27 09:42:35 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-27 10:14:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8a9ff47 into main Feb 27, 2025
332 checks passed
@dd-mergequeue dd-mergequeue bot deleted the valeri.pliskin/wms-add-totalcores branch February 27, 2025 10:14
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 27, 2025
purple4reina added a commit that referenced this pull request Feb 27, 2025
@purple4reina
Revert "WMS: GPU entity fixes (#34490)"
15ead01 
This reverts commit 8a9ff47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjulianm gjulianm gjulianm approved these changes

@wdhif wdhif wdhif approved these changes

Assignees
No one assigned
Labels
ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Milestone
7.65.0
Development

Successfully merging this pull request may close these issues.
3 participants
@val06 @gjulianm @wdhif