Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-203] make configsync a go module #34373

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Feb 24, 2025

What does this PR do?

Make configsync a go module
split from #33564

Motivation

working towards https://datadoghq.atlassian.net/browse/OTAGENT-203

Describe how you validated your changes

existing tests should cover

@songy23 songy23 added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent labels Feb 24, 2025
@songy23 songy23 added this to the 7.65.0 milestone Feb 24, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Uncompressed package size comparison

Comparison with ancestor 71976644f4723863d87a94ed4d10abb5872da87c

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.00MB 440.71MB 440.71MB 0.50MB
datadog-agent-amd64-deb 0.00MB 815.42MB 815.42MB 0.50MB
datadog-agent-arm64-deb 0.00MB 806.37MB 806.37MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 825.21MB 825.21MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 825.21MB 825.21MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 816.14MB 816.14MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.42MB 59.42MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.18MB 62.18MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.18MB 62.18MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.43MB 39.43MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.97MB 37.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.11MB 62.11MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.35MB 59.35MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Feb 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 31f766d4-61aa-4a8a-bec0-50c20180f12d

Baseline: 7197664
Comparison: eade76b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.70 [+0.65, +0.76] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.51 [+0.04, +0.99] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.75, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.77, +0.81] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.75, +0.78] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.68, +0.71] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.87, +0.81] 1 Logs
quality_gate_idle memory utilization -0.08 [-0.11, -0.05] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.22 [-1.00, +0.57] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.65 [-1.53, +0.22] 1 Logs
quality_gate_idle_all_features memory utilization -0.78 [-0.84, -0.72] 1 Logs bounds checks dashboard
file_tree memory utilization -0.97 [-1.02, -0.92] 1 Logs
quality_gate_logs % cpu utilization -2.01 [-4.94, +0.92] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@songy23 songy23 changed the title [OTAGENT-203] make otel-agent a go module [OTAGENT-203] make configsync and internal/runcmd go modules Feb 24, 2025
@songy23 songy23 force-pushed the yang.song/OTAGENT-203 branch from bc2353a to 9956d9a Compare February 25, 2025 19:57
@songy23 songy23 force-pushed the yang.song/OTAGENT-203 branch from 9956d9a to 03cd5f0 Compare February 25, 2025 20:35
@songy23 songy23 changed the title [OTAGENT-203] make configsync and internal/runcmd go modules [OTAGENT-203] make configsync a go modules Feb 25, 2025
@songy23 songy23 marked this pull request as ready for review February 25, 2025 20:36
@songy23 songy23 requested review from a team as code owners February 25, 2025 20:36
@songy23 songy23 changed the title [OTAGENT-203] make configsync a go modules [OTAGENT-203] make configsync a go module Feb 25, 2025
@@ -17,6 +17,7 @@ modules:
comp/api/authtoken: default
comp/core/config:
used_by_otel: true
comp/core/configsync: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have used_by_otel: true?

Copy link
Contributor

@jeremy-hanna jeremy-hanna Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, I see the answer from the other comment and this will be used in the embedded collector

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now no, this is only used in the embedded collector, not in OSS collector

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57582713 --os-family=ubuntu

Note: This applies to commit eade76b

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 789.04MiB 801.8MiB 192.34MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.49MiB 793.14MiB 174.3MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 789.11MiB 801.79MiB 194.37MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.41MiB 793.09MiB 175.81MiB 186.44MiB
static_quality_gate_agent_suse_amd64 789.09MiB 801.81MiB 194.37MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.49MiB 793.14MiB 175.81MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.68MiB 47.67MiB 9.79MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.29MiB 46.27MiB 8.49MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.68MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.31MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.68MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.31MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.68MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.31MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.79MiB 886.12MiB 293.94MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.43MiB 900.79MiB 280.17MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.02MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.23MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.83MiB 55.78MiB 17.29MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.47MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 265.01MiB 274.78MiB 106.35MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.98MiB 290.82MiB 101.2MiB 111.12MiB

Copy link
Contributor

@rahulkaukuntla rahulkaukuntla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Agent Configuration

@songy23
Copy link
Member Author

songy23 commented Mar 3, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 3, 2025

View all feedbacks in Devflow UI.
2025-03-03 22:34:15 UTC ℹ️ Start processing command /merge


2025-03-03 22:34:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-03 23:20:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 32m.


2025-03-04 00:16:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a416523 into main Mar 4, 2025
436 of 439 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTAGENT-203 branch March 4, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants