Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/pjbgf/sha1cd to v0.3.2 #33883

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Bump the sha1cd dependency to include the fix for pjbgf/sha1cd#148. This allows to fully drop the avo dependency.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux requested a review from a team as a code owner February 10, 2025 19:48
@github-actions github-actions bot added medium review PR review might take time team/agent-devx-loops labels Feb 10, 2025
@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests ask-review Ask required teams to review this PR labels Feb 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor fb5226571d1dc89a0229d83fcee14e0217a6355c

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.07MB 441.07MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.35MB 86.35MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.63MB 82.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.70MB 82.70MB 0.50MB
datadog-agent-aarch64-rpm -3.30MB 863.98MB 867.28MB 0.50MB
datadog-agent-arm64-deb -3.30MB 854.23MB 857.53MB 0.50MB
datadog-agent-amd64-deb -3.40MB 865.71MB 869.11MB 0.50MB
datadog-agent-x86_64-rpm -3.40MB 875.48MB 878.88MB 0.50MB
datadog-agent-x86_64-suse -3.40MB 875.48MB 878.88MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 836.96MiB 858.45MiB 202.94MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.77MiB 942.69MiB 308.7MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.14MiB 952.69MiB 292.69MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.79MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.78MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.25MiB 56.27MiB 17.05MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.26MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.74MiB 293.73MiB 102.1MiB 112.12MiB

Copy link

cit-pr-commenter bot commented Feb 10, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4a71666b-b7cf-4feb-864f-29bacd2638aa

Baseline: 8334f3e
Comparison: 8334f3e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.22 [-0.65, +1.10] 1 Logs
quality_gate_idle memory utilization +0.21 [+0.17, +0.25] 1 Logs bounds checks dashboard
file_tree memory utilization +0.10 [+0.03, +0.16] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.09 [-0.77, +0.95] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.07 [-0.63, +0.76] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.83, +0.94] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.78, +0.79] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
quality_gate_idle_all_features memory utilization +0.00 [-0.06, +0.06] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput -0.00 [-0.27, +0.27] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.03 [-0.50, +0.43] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.83, +0.73] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.92, +0.80] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.15 [-0.22, -0.07] 1 Logs
quality_gate_logs % cpu utilization -1.72 [-4.70, +1.26] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Member

chouetz commented Feb 11, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 11, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-11 08:06:30 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 31m.


2025-02-11 08:43:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8334f3e into main Feb 11, 2025
454 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/bump-sha1cd branch February 11, 2025 08:43
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants