[CWS-1120] Merge activity dump and security profile managers #33877

YoannGh · 2025-02-10T15:29:11Z

What does this PR do?

Merge activity dump and security profile managers into a single manager responsible for handling both types of object
Refactor the activity dump and security profile data types, introducing a new Profile type that includes fields used for both activity collection (dump) and profile lookups.

Motivation

Remove the need to unmarshal every newly created activity dump to check whether it should be loaded to be used as a security profile

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cmd/security-agent/subcommands/runtime/activity_dump.go

pkg/security/security_profile/profile/profile.go

spikat · 2025-02-18T14:15:43Z

pkg/security/security_profile/profile/profile.go

+	for _, workload := range p.Instances {
+		if entry.ContainerID == workload.ContainerID {
+			return true
+		}
 	}


Not directly linked to your PR, but this looks insufficient for the new cgroup selectors

pkg/security/security_profile/directory.go

pkg/security/security_profile/manager.go

cit-pr-commenter · 2025-02-26T20:23:28Z

Go Package Import Differences

Baseline: a6dee66
Comparison: b850f51

binary	os	arch	change
security-agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/pkg/security/security_profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage
security-agent	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/pkg/security/security_profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage
security-agent	windows	amd64	+2, -1 -github.com/DataDog/datadog-agent/pkg/security/security_profile/dump +github.com/DataDog/datadog-agent/pkg/security/security_profile/profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage
system-probe	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/pkg/security/security_profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage
system-probe	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/pkg/security/security_profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage
system-probe	windows	amd64	+2, -1 -github.com/DataDog/datadog-agent/pkg/security/security_profile/dump +github.com/DataDog/datadog-agent/pkg/security/security_profile/profile +github.com/DataDog/datadog-agent/pkg/security/security_profile/storage

agent-platform-auto-pr · 2025-02-26T20:42:32Z

Uncompressed package size comparison

Comparison with ancestor a6dee66fdbf32e3d36d7497f8afc08d5816b6af7

Size reduction summary

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	-0.11MB	✅	815.72MB	815.83MB	0.50MB
datadog-agent-arm64-deb	-0.11MB	✅	805.95MB	806.06MB	0.50MB
datadog-agent-amd64-deb	-0.12MB	✅	815.06MB	815.18MB	0.50MB
datadog-agent-x86_64-rpm	-0.12MB	✅	824.85MB	824.98MB	0.50MB
datadog-agent-x86_64-suse	-0.12MB	✅	824.85MB	824.98MB	0.50MB

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.46MB	39.46MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.54MB	39.54MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.54MB	39.54MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.99MB	37.99MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	440.86MB	440.86MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.14MB	62.14MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.21MB	62.21MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.20MB	62.20MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.36MB	59.36MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.43MB	59.43MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-02-26T21:09:10Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 79bd02e6-b4bb-4c67-a00d-31bf5656987a

Baseline: a6dee66
Comparison: b850f51
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.63	[-1.30, +4.56]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.47	[+0.58, +2.36]	1	Logs
➖	quality_gate_idle	memory utilization	+0.65	[+0.59, +0.70]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.46	[-0.02, +0.93]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.38	[+0.35, +0.41]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.74, +0.75]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.00	[-0.74, +0.74]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.73, +0.71]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.32, +0.29]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.78, +0.73]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.82, +0.74]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.84, +0.74]	1	Logs
➖	file_tree	memory utilization	-0.29	[-0.35, -0.23]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.52	[-1.58, -1.47]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

lebauce · 2025-02-27T10:15:10Z

pkg/security/security_profile/ad.go

+
+		defaultConfig, found := defaultConfigs[containerutils.CGroupManager(workloads[0].CGroupContext.CGroupFlags)]
+		if !found {
+			seclog.Errorf("Failed to find default activity dump config for %s", containerutils.CGroupManager(workloads[0].CGroupContext.CGroupFlags).String())


Could we display the CGroupID too ?

Done with 1b9ba39

agent-platform-auto-pr · 2025-02-27T18:47:32Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=57942452 --os-family=ubuntu

Note: This applies to commit b850f51

agent-platform-auto-pr · 2025-02-27T18:49:49Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	788.82MiB	801.8MiB	192.31MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	780.06MiB	793.14MiB	174.47MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	788.77MiB	801.79MiB	194.37MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	780.01MiB	793.09MiB	175.87MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	788.79MiB	801.81MiB	194.37MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	780.05MiB	793.14MiB	175.87MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.71MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.3MiB	46.27MiB	8.48MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.71MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.71MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.33MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.69MiB	66.4MiB	12.84MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.33MiB	69.0MiB	14.93MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.69MiB	66.4MiB	12.87MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.33MiB	69.0MiB	14.93MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	873.45MiB	886.12MiB	293.86MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	888.02MiB	900.79MiB	280.09MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	368.97MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.14MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.86MiB	55.78MiB	17.3MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.47MiB	54.45MiB	16.17MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	265.09MiB	274.78MiB	106.42MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	281.02MiB	290.82MiB	101.21MiB	111.12MiB

YoannGh added changelog/no-changelog team/agent-security qa/rc-required Only for a PR that requires validation on the Release Candidate labels Feb 10, 2025

YoannGh requested review from a team as code owners February 10, 2025 15:29

github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Feb 10, 2025

YoannGh changed the title ~~[CWS] Merge activity dump and security profile managers~~ [CWS-1120] Merge activity dump and security profile managers Feb 10, 2025

spikat reviewed Feb 18, 2025

View reviewed changes

spikat reviewed Feb 19, 2025

View reviewed changes

YoannGh force-pushed the yoanngh/merge-ad-and-profile-managers branch from 09defad to 2d49296 Compare February 26, 2025 19:36

lebauce reviewed Feb 27, 2025

View reviewed changes

spikat approved these changes Feb 27, 2025

View reviewed changes

YoannGh force-pushed the yoanngh/merge-ad-and-profile-managers branch from 1b9ba39 to 2a2e9ba Compare February 27, 2025 18:08

YoannGh force-pushed the yoanngh/merge-ad-and-profile-managers branch from 2a2e9ba to 14687ce Compare March 4, 2025 09:09

brycekahle approved these changes Mar 4, 2025

View reviewed changes

YoannGh force-pushed the yoanngh/merge-ad-and-profile-managers branch from c09f92d to 7f93af8 Compare March 6, 2025 10:38

YoannGh added 8 commits March 6, 2025 15:49

merge activity dump and security profile managers

f14627d

add directory unit tests

723d4b6

cleanup

2bc5835

add ProfileOpts

b8ef31a

use slices.Contains in AddTags

01d3cfa

getSelectorStr uses selector.String()

10852bb

rename insertion functions and extract image_tag parameter for AD

68c88d8

use selector to get image name and tag

9095327

YoannGh added 9 commits March 6, 2025 15:49

add comment for test function

953da6d

update onNewProfile comment

a62ab10

add comments on elseif case

94aa1be

do not use temporary map when reading files from directory

600cc7f

simplify directory profile mapping

967ab4d

add storage package

11084cc

move DefaultProfileName constant

ec0bd84

split manager into multiple files

684f342

log cgroup ID along with its manager

b850f51

YoannGh force-pushed the yoanngh/merge-ad-and-profile-managers branch from 7f93af8 to b850f51 Compare March 6, 2025 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CWS-1120] Merge activity dump and security profile managers #33877

[CWS-1120] Merge activity dump and security profile managers #33877

YoannGh commented Feb 10, 2025

spikat Feb 18, 2025

cit-pr-commenter bot commented Feb 26, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 26, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 26, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

lebauce Feb 27, 2025

YoannGh Feb 27, 2025

agent-platform-auto-pr bot commented Feb 27, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 27, 2025 •

edited

Loading

Info

[CWS-1120] Merge activity dump and security profile managers #33877

Are you sure you want to change the base?

[CWS-1120] Merge activity dump and security profile managers #33877

Conversation

YoannGh commented Feb 10, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

spikat Feb 18, 2025

Choose a reason for hiding this comment

cit-pr-commenter bot commented Feb 26, 2025 • edited Loading

Go Package Import Differences

agent-platform-auto-pr bot commented Feb 26, 2025 • edited Loading

Uncompressed package size comparison

Decision

cit-pr-commenter bot commented Feb 26, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

lebauce Feb 27, 2025

Choose a reason for hiding this comment

YoannGh Feb 27, 2025

Choose a reason for hiding this comment

agent-platform-auto-pr bot commented Feb 27, 2025 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Feb 27, 2025 • edited Loading

Static quality checks ✅

Info

cit-pr-commenter bot commented Feb 26, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 26, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 26, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 27, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 27, 2025 •

edited

Loading