Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Omnibus tooling to support Python checks defined by a pyproject.toml file #10694

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Update Omnibus tooling to support Python checks defined by a pyproject.toml file #10694

merged 5 commits into from
Feb 4, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 28, 2022

@ofek ofek added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. team/integrations [deprecated] team/agent-platform labels Jan 28, 2022
@ofek ofek added this to the 7.35.0 milestone Jan 28, 2022
@ofek ofek requested review from a team as code owners January 28, 2022 03:08
@julien-lebot
Copy link
Contributor

Could you document how to QA those changes ? If no QA is required, could you add the skip-qa label ?

@mx-psi mx-psi mentioned this pull request Jan 28, 2022
Closed
9 tasks
@mx-psi
Copy link
Member

mx-psi commented Jan 28, 2022

CI should be fixed by #10696, I am testing that

@ofek ofek added [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card changelog/no-changelog labels Jan 28, 2022
apigirl
apigirl reviewed Jan 28, 2022
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review needed

@ofek ofek mentioned this pull request Feb 1, 2022
Merged
truthbk
truthbk approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 📦

@ofek ofek merged commit 4e64b18 into main Feb 4, 2022
@ofek ofek deleted the ofek/build branch February 4, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apigirl apigirl apigirl left review comments

@yzhan289 yzhan289 yzhan289 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@truthbk truthbk truthbk approved these changes

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. [deprecated] team/agent-platform team/integrations
Projects
None yet
Milestone
7.35.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ofek @julien-lebot @mx-psi @djmitche @truthbk @apigirl @yzhan289