Exploration Testing

pkg/dynamicinstrumentation/diconfig/binary_inspection.go

@@ -21,17 +21,23 @@ import (
 // inspectGoBinaries goes through each service and populates information about the binary
 // and the relevant parameters, and their types
 // configEvent maps service names to info about the service and their configurations
-func inspectGoBinaries(configEvent ditypes.DIProcs) bool {
+func inspectGoBinaries(configEvent ditypes.DIProcs) error {
+	var err error
 	var inspectedAtLeastOneBinary bool
 	for i := range configEvent {
-		err := AnalyzeBinary(configEvent[i])
+		err = AnalyzeBinary(configEvent[i])
 		if err != nil {
 			log.Info("inspection of PID %d (path=%s) failed: %w", configEvent[i].PID, configEvent[i].BinaryPath, err)
 		} else {
 			inspectedAtLeastOneBinary = true
 		}
 	}
-	return inspectedAtLeastOneBinary
+
+	if !inspectedAtLeastOneBinary {
+		return fmt.Errorf("failed to inspect all tracked go binaries")
+	}
+
+	return nil
 }
 
 // AnalyzeBinary reads the binary associated with the specified process and parses

pkg/dynamicinstrumentation/diconfig/mem_config_manager.go

@@ -80,9 +80,9 @@ func (cm *ReaderConfigManager) update() error {
 	}
 
 	if !reflect.DeepEqual(cm.state, updatedState) {
-		atLeastOneBinaryAnalyzed := inspectGoBinaries(updatedState)
-		if !atLeastOneBinaryAnalyzed {
-			return fmt.Errorf("failed to inspect all tracked go binaries.")
+		err := inspectGoBinaries(updatedState)
+		if err != nil {
+			return err
 		}
 
 		for pid, procInfo := range cm.state {

pkg/dynamicinstrumentation/proctracker/proctracker.go

@@ -84,7 +84,7 @@ func (pt *ProcessTracker) Stop() {
 	}
 }
 
-func (pt *ProcessTracker) Test_HandleProcessStart(pid uint32) {
+func (pt *ProcessTracker) HandleProcessStartSync(pid uint32) {
 	exePath := filepath.Join(pt.procRoot, strconv.FormatUint(uint64(pid), 10), "exe")
 
 	pt.inspectBinary(exePath, pid)