Do not exclude dummy devices during local addr detection #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Processes like nodelocaldns might setup a dummy device and attach a custom IP to them. But these devices aren't always brought up. If nodelocaldns IP isn't recognized as a local address, when bpf host routing is used, traffic to NLD IP would go through fib_lookup. This lookup will fail because fib_lookup doesn't work for local routes. This is currently a blocker for enabling bpf host routing while using nodelocaldns in host network. This is a 1.14 variant of cilium#34228 Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
jaredledvina
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processes like nodelocaldns might setup a dummy device and attach a custom IP to them. But these devices aren't always brought up. If nodelocaldns IP isn't recognized as a local address, when bpf host routing is used, traffic to NLD IP would go through fib_lookup. This lookup will fail because fib_lookup doesn't work for local routes.
This is currently a blocker for enabling bpf host routing while using nodelocaldns in host network.
This is a 1.14 variant of cilium#34228 since statedb based node address management is introduced only in 1.15 and above.