Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOSTRIP #549

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix NOSTRIP #549

merged 1 commit into from
Mar 6, 2024

Conversation

EricMountain
Copy link
Member

@EricMountain EricMountain commented Mar 6, 2024

NOSTRIP was incorrectly coded into the debug build: it needs to be passed as a Docker build arg.

delve works better this way:

(dlv) bt
0  0x0000000000407e8e in runtime/internal/syscall.Syscall6
   at /usr/local/go/src/runtime/internal/syscall/asm_linux_amd64.s:36
1  0x0000000000407e05 in runtime/internal/syscall.EpollWait
   at /usr/local/go/src/runtime/internal/syscall/syscall_linux.go:55
2  0x00000000004371ab in runtime.netpoll
   at /usr/local/go/src/runtime/netpoll_epoll.go:118
3  0x0000000000443185 in runtime.findRunnable
   at /usr/local/go/src/runtime/proc.go:3191
4  0x00000000004442f1 in runtime.schedule
   at /usr/local/go/src/runtime/proc.go:3582
5  0x00000000004447ff in runtime.park_m
   at /usr/local/go/src/runtime/proc.go:3745
6  0x000000000046ba2e in runtime.mcall
   at /usr/local/go/src/runtime/asm_amd64.s:458

# Maybe wrong, but at least it doesn't panic:
(dlv) args
(no args)

(dlv) grs
  Goroutine 1 - User: /go/pkg/mod/github.com/go-delve/delve@v1.22.0/cmd/dlv/cmds/commands.go:898 github.com/go-delve/delve/cmd/dlv/cmds.waitForDisconnectSignal (0x9d641d) [select]
  Goroutine 2 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [force gc (idle) 156123584244879]
  Goroutine 3 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [GC sweep wait]
  Goroutine 4 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [GC scavenge wait]
  Goroutine 5 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [debug call]
  Goroutine 11 - User: /usr/local/go/src/runtime/internal/syscall/syscall_linux.go:38 syscall.RawSyscall6 (0x407e6d) (thread 24) [chan receive]
  Goroutine 18 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [finalizer wait 156123584244879]
  Goroutine 19 - User: /go/pkg/mod/github.com/go-delve/delve@v1.22.0/pkg/proc/native/proc.go:400 github.com/go-delve/delve/pkg/proc/native.(*ptraceThread).handlePtraceFuncs (0x88a357) [chan receive]
  Goroutine 20 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [debug call]
  Goroutine 21 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [debug call 156125290278278]
  Goroutine 22 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [debug call]
  Goroutine 34 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [debug call]
  Goroutine 35 - User: /usr/local/go/src/net/fd_unix.go:172 net.(*netFD).accept (0x549ea9) [IO wait]
  Goroutine 37 - User: /usr/local/go/src/runtime/sigqueue.go:152 os/signal.signal_recv (0x46a309) (thread 23)
  Goroutine 50 - User: /usr/local/go/src/runtime/proc.go:399 runtime.gopark (0x43de2e) [select]

@EricMountain EricMountain force-pushed the eric.mountain/nostrip branch from 32c2e2f to c4c79cb Compare March 6, 2024 13:31
@EricMountain EricMountain merged commit 20a2e40 into v1.13-dd Mar 6, 2024
21 of 33 checks passed
@EricMountain EricMountain deleted the eric.mountain/nostrip branch March 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants