Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: define new flags to control Cilium's datapath events notifications #546

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

EricMountain
Copy link
Member

@EricMountain EricMountain commented Feb 22, 2024

Cherry-pick of cilium#30063 (430ccca).


This commit introduces three new configuration flags for the Cilium agent, allowing users to choose the bpf event types they want to expose to Cilium monitor and Hubble.

  • --bpf-events-drop-enabled Expose 'drop' events for Cilium monitor and/or Hubble (default true)
  • --bpf-events-policy-verdict-enabled Expose 'policy verdict' events for Cilium monitor and/or Hubble (default true)
  • --bpf-events-trace-enabled Expose 'trace' events for Cilium monitor and/or Hubble (default true)

The default values for these flags remain set to true, not changing the current behaviour.

In our case, we found particularly useful to disable the TraceNotification in order to reduce the CPU overhead on some of our nodes when Hubble is enabled as we were mostly interested into dropped packets.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

…ions

This commit introduces three new configuration flags for the Cilium agent, allowing users to choose the bpf event types they want to expose to Cilium monitor and Hubble.
 - `--bpf-events-drop-enabled`                                   Expose 'drop' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-policy-verdict-enabled`                         Expose 'policy verdict' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-trace-enabled`                                  Expose 'trace' events for Cilium monitor and/or Hubble (default true)

The default values for these flags remain set to `true`, not changing the current behaviour.

In our case, we found particularly useful to disable the TraceNotification in order to reduce the CPU overhead on some of our nodes when Hubble is enabled as we were mostly interested into dropped packets.

Signed-off-by: Maxime Visonneau <maxime.visonneau@gmail.com>
@EricMountain EricMountain requested a review from a team February 22, 2024 10:25
@EricMountain EricMountain marked this pull request as ready for review February 22, 2024 10:37
@EricMountain EricMountain merged commit 874d47b into v1.13-dd Feb 22, 2024
19 of 34 checks passed
@EricMountain EricMountain deleted the eric.mountain/mvisonneau-30063-notif-flags branch February 22, 2024 15:08
EricMountain added a commit that referenced this pull request Feb 22, 2024
EricMountain added a commit that referenced this pull request Feb 22, 2024
EricMountain added a commit that referenced this pull request Feb 23, 2024
…ions (#546)

This commit introduces three new configuration flags for the Cilium agent, allowing users to choose the bpf event types they want to expose to Cilium monitor and Hubble.
 - `--bpf-events-drop-enabled`                                   Expose 'drop' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-policy-verdict-enabled`                         Expose 'policy verdict' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-trace-enabled`                                  Expose 'trace' events for Cilium monitor and/or Hubble (default true)

The default values for these flags remain set to `true`, not changing the current behaviour.

In our case, we found particularly useful to disable the TraceNotification in order to reduce the CPU overhead on some of our nodes when Hubble is enabled as we were mostly interested into dropped packets.

Signed-off-by: Maxime Visonneau <maxime.visonneau@gmail.com>
Co-authored-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
EricMountain added a commit that referenced this pull request Feb 23, 2024
…ions (#546)

This commit introduces three new configuration flags for the Cilium agent, allowing users to choose the bpf event types they want to expose to Cilium monitor and Hubble.
 - `--bpf-events-drop-enabled`                                   Expose 'drop' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-policy-verdict-enabled`                         Expose 'policy verdict' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-trace-enabled`                                  Expose 'trace' events for Cilium monitor and/or Hubble (default true)

The default values for these flags remain set to `true`, not changing the current behaviour.

In our case, we found particularly useful to disable the TraceNotification in order to reduce the CPU overhead on some of our nodes when Hubble is enabled as we were mostly interested into dropped packets.

Signed-off-by: Maxime Visonneau <maxime.visonneau@gmail.com>
Co-authored-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
EricMountain added a commit that referenced this pull request Feb 23, 2024
…ions (#546) (#548)

This commit introduces three new configuration flags for the Cilium agent, allowing users to choose the bpf event types they want to expose to Cilium monitor and Hubble.
 - `--bpf-events-drop-enabled`                                   Expose 'drop' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-policy-verdict-enabled`                         Expose 'policy verdict' events for Cilium monitor and/or Hubble (default true)
 - `--bpf-events-trace-enabled`                                  Expose 'trace' events for Cilium monitor and/or Hubble (default true)

The default values for these flags remain set to `true`, not changing the current behaviour.

In our case, we found particularly useful to disable the TraceNotification in order to reduce the CPU overhead on some of our nodes when Hubble is enabled as we were mostly interested into dropped packets.

Signed-off-by: Maxime Visonneau <maxime.visonneau@gmail.com>
Co-authored-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants