Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CORE-182] Move listRuntimes over to new Sam permissions model (#4810)" #4823

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

marctalbott
Copy link
Member

This reverts commit 1030a2c.

This wasn't the cleanest revert since some of the dependencies required to revert had been removed in a separate PR.

Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (3fd8cc2) to head (2ebeac7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...orkbench/leonardo/db/RuntimeServiceDbQueries.scala 93.02% 3 Missing ⚠️
...h/leonardo/http/service/RuntimeServiceInterp.scala 88.88% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4823      +/-   ##
===========================================
+ Coverage    74.62%   74.77%   +0.15%     
===========================================
  Files          166      166              
  Lines        14690    14800     +110     
  Branches      1158     1112      -46     
===========================================
+ Hits         10962    11067     +105     
- Misses        3728     3733       +5     
Files with missing lines Coverage Δ
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.88% <100.00%> (+0.01%) ⬆️
...leonardo/http/service/RuntimeV2ServiceInterp.scala 96.12% <100.00%> (+0.67%) ⬆️
...orkbench/leonardo/db/RuntimeServiceDbQueries.scala 96.31% <93.02%> (-0.38%) ⬇️
...h/leonardo/http/service/RuntimeServiceInterp.scala 91.54% <88.88%> (-0.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd8cc2...2ebeac7. Read the comment docs.

Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that, it is painful to see the old listRuntimes coming back, but it is only temporary to make sure AOU functionality keeps working while we find an alternate solution.

@marctalbott marctalbott marked this pull request as ready for review January 17, 2025 22:46
@marctalbott marctalbott requested a review from a team as a code owner January 17, 2025 22:46
@marctalbott marctalbott merged commit 9cdf0d0 into develop Jan 17, 2025
23 checks passed
@marctalbott marctalbott deleted the mtalbott-revert-listRuntimes branch January 17, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants