Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked at logs a bit closer. There were redelivered messages. Not sure exactly why...Found googleapis/google-cloud-python#9252, which may happen with java client as well...Regardless whether this is something the client should fix, we should make things as idempotent as we can...Currently when we redeliver the same message, Leonardo will mark the runtime as Errored, while in reality the runtime was created fine.
Another thing worth considering is adding some logic for deduping messages in leo
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: