Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-1875 More improvement #1376

Merged
merged 1 commit into from
Apr 27, 2020
Merged

IA-1875 More improvement #1376

merged 1 commit into from
Apr 27, 2020

Conversation

Qi77Qi
Copy link
Collaborator

@Qi77Qi Qi77Qi commented Apr 24, 2020

Looked at logs a bit closer. There were redelivered messages. Not sure exactly why...Found googleapis/google-cloud-python#9252, which may happen with java client as well...Regardless whether this is something the client should fix, we should make things as idempotent as we can...Currently when we redeliver the same message, Leonardo will mark the runtime as Errored, while in reality the runtime was created fine.

Another thing worth considering is adding some logic for deduping messages in leo


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've documented my API changes in Swagger

In all cases:

  • Get a thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; Delete your branch after this
  • Test this change deployed correctly and works on dev environment after deployment

@Qi77Qi Qi77Qi changed the title [no ticket] More improvement IA-1875 More improvement Apr 24, 2020
@Qi77Qi Qi77Qi merged commit 736e07c into develop Apr 27, 2020
@Qi77Qi Qi77Qi deleted the improve branch April 27, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants