DR-3408: SqlSortDirection Model no longer generated

[snf2ye]

https://broadworkbench.atlassian.net/browse/DR-3408

---

With a recent TDR change, we no longer generate the "SqlSortDirection" model via swagger. Instead we generate "SqlSortDirectionAscDefault" and "SqlSortDirectionDescDefault" models.

Since we are now setting a default for the query data endpoint in the TDR code, we can pass through an empty sort direction and it will default to "asc." So, we can remove the empty string handling and the reference to the SQLSortDirection model.

A few notes:
How we sort in the UI

• By default, we sort by the datarepo_row_id "desc" when viewing data in the UI
• However, we do not show the datarepo_row_id, so the order looks random.

This is not ideal. We should instead default to sorting by the first non-datarepo-row-id, default to "asc". But, this needs to be communicated well with the users so that they're not confused as to why their data is suddenly appearing different to them. Added ticket for this - DR-3407

We missed that the UI code was no longer building

• Our UI e2e tests have been failing for a week, but we haven't noticed because we do not send nightly test failure alerts to the sack. We should add a slack notification on failure. https://broadworkbench.atlassian.net/browse/DR-3406

[cypress]

Passing run #3150 ↗︎

0

25

0

0

0

Details:

Merge 917409b into 74b9afc...
Project: jade-data-repo-ui	Commit: 9f80f4e191 ℹ️
Status: Passed	Duration: 04:12 💡
Started: Dec 20, 2023 2:17 PM	Ended: Dec 20, 2023 2:22 PM

Review all test suite changes for PR #1572 ↗︎

[okotsopoulos]

Thanks for fixing and filing those follow-on tickets!

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[rushtong]

LGTM 👍🏽