-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Python runtime to 3.8.12 (#3439) #3478
Conversation
a835d49
to
33e6ff7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3478 +/- ##
========================================
Coverage 81.91% 81.91%
========================================
Files 123 123
Lines 14281 14281
========================================
Hits 11698 11698
Misses 2583 2583 Continue to review full report at Codecov.
|
Self note: 33e6ff798f5afc8f21c042ed4e8cd47b3ec44e06 passes IT, installed 3.8.12 + make req + deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more mentions of 3.8.3 were just introduced:
33e6ff7
to
39a4a66
Compare
39a4a66
to
eaa7f4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the commit I just pushed. Since this touches the Dockerfile, it needs to be tagged R
and labeled reqs
and so on.
eaa7f4a
to
6005f3a
Compare
Self Note: added announcement, Updated commit tags, PR tags, ran |
6005f3a
to
838b96e
Compare
Failed |
a3af5e6
to
536de3c
Compare
@hannes-ucsc I pinned tzlocal==4.0.1b1 and added a FIXME to remove the pinned beta when there is a new version released. Here is the related issue regebro/tzlocal#121 |
requirements.txt
Outdated
@@ -36,6 +36,9 @@ requests-http-signature==0.0.3 | |||
requests==2.26.0 | |||
rsa==4.7 | |||
typing-extensions==3.7.4 | |||
# FIXME: Remove pinned beta version when tzlocal is updated | |||
# https://github.com/regebro/tzlocal/issues/121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should refer to an Azul ticket that reference the tzlocal ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.0.1 was released, no need for a FIXME.
536de3c
to
6b94910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator (@achave11), don't merge this before the promotion tomorrow. I want to let this stew in dev
for a week.
6b94910
to
db6de63
Compare
I remember that I was on the hook to fix something here but I don't remember what it was. But it looks like you've got this under control, @achave11. |
db6de63
to
ab910cf
Compare
#3439
Python 3.8.3 patch is no longer needed after python/cpython#21154 was backported to 3.8.4 and above.
Announcement: "Heads up, you'll need to update to python 3.8.12 when you rebase."
Author
Fix:
for bugs) or there is a good reason why they're differentAuthor (reindex)
r
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingAuthor (freebies & chains)
chain
label to the blocking PR or this PR is not chained to another PRAuthor (upgrading)
u
tag to commit title or this PR does not require upgradingupgrade
label to PR or this PR does not require upgradingAuthor (requirements, before every review)
make requirements_update
or this PR leaves requirements*.txt, common.mk and Makefile untouchedR
tag to commit title or this PR leaves requirements*.txt untouchedreqs
label to PR or this PR leaves requirements*.txt untouchedAuthor (before every review)
make integration_test
passes in personal deployment or this PR does not touch functionality that could break the ITdevelop
, squashed old fixupsPrimary reviewer (after approval)
no demo
no sandbox
Operator (before pushing merge the commit)
reindex
label andr
commit title tagno demo
sandbox
label or PR is labeledno sandbox
no sandbox
sandbox
or this PR does not require reindexingsandbox
sandbox
or this PR does not require reindexingsandbox
Operator (after pushing the merge commit)
N reviews
labelling is accurateOperator (reindex)
dev
or this PR does not require reindexing or does not targetdev
dev
or this PR does not require reindexing or does not targetdev
prod
or this PR does not require reindexing or does not targetprod
prod
or this PR does not require reindexing or does not targetprod
Operator