Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python runtime to 3.8.12 (#3439) #3478

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

amarjandu
Copy link
Contributor

@amarjandu amarjandu commented Sep 29, 2021

#3439

Python 3.8.3 patch is no longer needed after python/cpython#21154 was backported to 3.8.4 and above.

Announcement: "Heads up, you'll need to update to python 3.8.12 when you rebase."

Author

  • PR title references issue
  • PR title matches issue title (preceded by Fix: for bugs) or there is a good reason why they're different
  • Title of main commit references issue
  • PR is connected to Zenhub issue and description links to issue

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (freebies & chains)

  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading
  • Added announcement to PR description or this PR does not require announcement

Author (requirements, before every review)

  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched

Author (before every review)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

  • Commented in issue about demo expectations or labelled issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to an operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to Github
  • Branch pushed to Gitlab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved linked issue to Merged column
  • Pushed merge commit to Github

Operator (after pushing the merge commit)

  • Made announcement requested by author or PR description does not contain an announcement
  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened the PR chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Deleted PR branch from Github and Gitlab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing or does not target dev
  • Checked for failures in dev or this PR does not require reindexing or does not target dev
  • Started reindex in prod or this PR does not require reindexing or does not target prod
  • Checked for failures in prod or this PR does not require reindexing or does not target prod

Operator

  • Unassigned PR

@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 29, 2021
@amarjandu amarjandu force-pushed the issues/amar/3439-update-python branch from a835d49 to 33e6ff7 Compare September 29, 2021 19:15
@amarjandu amarjandu added the upgrade [process] PR includes commit requiring manual upgrade label Sep 29, 2021
@coveralls
Copy link

coveralls commented Sep 29, 2021

Coverage Status

Coverage remained the same at 82.161% when pulling ab910cf on issues/amar/3439-update-python into 6ac7a60 on develop.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #3478 (ab910cf) into develop (6ac7a60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3478   +/-   ##
========================================
  Coverage    81.91%   81.91%           
========================================
  Files          123      123           
  Lines        14281    14281           
========================================
  Hits         11698    11698           
  Misses        2583     2583           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac7a60...ab910cf. Read the comment docs.

@amarjandu
Copy link
Contributor Author

Self note: 33e6ff798f5afc8f21c042ed4e8cd47b3ec44e06 passes IT, installed 3.8.12 + make req + deploy

Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@dsotirho-ucsc dsotirho-ucsc removed their assignment Sep 30, 2021
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannes-ucsc hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Oct 6, 2021
@hannes-ucsc hannes-ucsc removed their assignment Oct 6, 2021
@amarjandu amarjandu force-pushed the issues/amar/3439-update-python branch from 33e6ff7 to 39a4a66 Compare October 6, 2021 17:02
@hannes-ucsc hannes-ucsc force-pushed the issues/amar/3439-update-python branch from 39a4a66 to eaa7f4a Compare October 11, 2021 20:44
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the commit I just pushed. Since this touches the Dockerfile, it needs to be tagged R and labeled reqs and so on.

@hannes-ucsc hannes-ucsc added 0 reviews [process] Lead didn't request any changes and removed 0 reviews [process] Lead didn't request any changes labels Oct 11, 2021
@hannes-ucsc hannes-ucsc removed their assignment Oct 11, 2021
@amarjandu amarjandu added the reqs [process] PR includes commit requiring ``make requirements`` label Oct 12, 2021
@amarjandu amarjandu force-pushed the issues/amar/3439-update-python branch from eaa7f4a to 6005f3a Compare October 12, 2021 16:30
@amarjandu
Copy link
Contributor Author

amarjandu commented Oct 12, 2021

Self Note: added announcement, Updated commit tags, PR tags, ran make ru, reindex + IT pass

@achave11-ucsc achave11-ucsc force-pushed the issues/amar/3439-update-python branch from 6005f3a to 838b96e Compare October 18, 2021 21:10
@achave11-ucsc achave11-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Oct 18, 2021
@achave11-ucsc
Copy link
Member

Failed sandbox during test job. https://gitlab.dev.singlecell.gi.ucsc.edu/ucsc/azul/-/jobs/31704 It might have been caused by a3af5e6.

@achave11-ucsc achave11-ucsc removed their assignment Oct 18, 2021
@achave11-ucsc achave11-ucsc removed the sandbox [process] Resolution is being verified in sandbox deployment label Oct 18, 2021
@amarjandu amarjandu force-pushed the issues/amar/3439-update-python branch from a3af5e6 to 536de3c Compare October 18, 2021 23:14
@amarjandu
Copy link
Contributor Author

amarjandu commented Oct 18, 2021

@hannes-ucsc I pinned tzlocal==4.0.1b1 and added a FIXME to remove the pinned beta when there is a new version released. Here is the related issue regebro/tzlocal#121

requirements.txt Outdated
@@ -36,6 +36,9 @@ requests-http-signature==0.0.3
requests==2.26.0
rsa==4.7
typing-extensions==3.7.4
# FIXME: Remove pinned beta version when tzlocal is updated
# https://github.com/regebro/tzlocal/issues/121
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should refer to an Azul ticket that reference the tzlocal ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.0.1 was released, no need for a FIXME.

@hannes-ucsc hannes-ucsc removed their assignment Oct 19, 2021
@amarjandu amarjandu force-pushed the issues/amar/3439-update-python branch from 536de3c to 6b94910 Compare October 19, 2021 18:27
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator (@achave11), don't merge this before the promotion tomorrow. I want to let this stew in dev for a week.

@hannes-ucsc hannes-ucsc removed their assignment Oct 19, 2021
@achave11-ucsc achave11-ucsc force-pushed the issues/amar/3439-update-python branch from 6b94910 to db6de63 Compare October 21, 2021 00:27
@achave11-ucsc achave11-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Oct 21, 2021
@hannes-ucsc
Copy link
Member

I remember that I was on the hook to fix something here but I don't remember what it was. But it looks like you've got this under control, @achave11.

@achave11-ucsc achave11-ucsc force-pushed the issues/amar/3439-update-python branch from db6de63 to ab910cf Compare October 21, 2021 02:47
@achave11-ucsc achave11-ucsc merged commit 127da37 into develop Oct 21, 2021
@achave11-ucsc achave11-ucsc deleted the issues/amar/3439-update-python branch October 21, 2021 03:57
@achave11-ucsc achave11-ucsc removed their assignment Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes orange [process] Done by the Azul team reqs [process] PR includes commit requiring ``make requirements`` sandbox [process] Resolution is being verified in sandbox deployment upgrade [process] PR includes commit requiring manual upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants