Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled issues do not have labels #6875

Open
dsotirho-ucsc opened this issue Feb 3, 2025 · 5 comments
Open

Scheduled issues do not have labels #6875

dsotirho-ucsc opened this issue Feb 3, 2025 · 5 comments
Assignees
Labels
+ [priority] High demo blocked [process] Demo is blocked by ongoing work demo [process] To be demonstrated at the end of the sprint infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team

Comments

@dsotirho-ucsc
Copy link
Contributor

dsotirho-ucsc commented Feb 3, 2025

#6875 (comment)

@dsotirho-ucsc dsotirho-ucsc added the orange [process] Done by the Azul team label Feb 3, 2025
@achave11-ucsc
Copy link
Member

achave11-ucsc commented Feb 3, 2025

Associated failed scheduled jobs:
https://github.com/DataBiosphere/azul/actions/runs/13086717507/job/36518730137

Run python3 .github/workflows/schedule.py
2025-02-01 08:0[6](https://github.com/DataBiosphere/azul/actions/runs/13086717507/job/36518730137#step:3:7):45,936    INFO azul.github.schedule: Running ['gh', 'issue', 'list', '--repo=DataBiosphere/azul-private', '--search=in:title "Monthly inventory review 2025-02-01"', '--json=number', '--limit=10']
2025-02-01 08:06:46,291    INFO azul.github.schedule: Running ['gh', 'issue', 'create', '--repo=DataBiosphere/azul-private', '--title=Monthly inventory review 2025-02-01', '--body=It is time for the system administrator to review the FedRAMP inventory and perform a Port and Protocol review in all deployments\n\n\n- [ ] Collect most recent `dev` inventories and attach them to this issue\n- [ ] Collect most recent `anvildev` inventories and attach them to this issue\n- [ ] Collect most recent `anvilprod` inventories and attach them to this issue\n- [ ] Collect most recent `prod` inventories and attach them to this issue\n\n- [ ] Reviewed `dev` inventory\n- [ ] Reviewed `anvildev` inventory\n- [ ] Reviewed `anvilprod` inventory\n- [ ] Reviewed `prod` inventory\n', '--assignee=hannes-ucsc', '--label=+,compliance,infra,no demo,operator,orange,task'] …
2025-02-01 08:06:4[7](https://github.com/DataBiosphere/azul/actions/runs/13086717507/job/36518730137#step:3:8),193    INFO azul.github.schedule: … created 'https://github.com/DataBiosphere/azul-private/issues/220', verifying labels and assignees …
2025-02-01 08:06:47,193    INFO azul.github.schedule: Running ['gh', 'issue', 'view', '--repo=DataBiosphere/azul-private', '--json=labels,assignees', '220'] …
Traceback (most recent call last):
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 249, in <module>
    main(sys.argv[1:])
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 243, in main
    self.create_issue(now.date())
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 219, in create_issue
    assert set(assignees) == actual_assignees, (assignees, actual_assignees)
AssertionError: (['hannes-ucsc'], set())
Error: Process completed with exit code 1.

https://github.com/DataBiosphere/azul/actions/runs/13086880418/job/36519070789

@dsotirho-ucsc dsotirho-ucsc added bug infra [subject] Project infrastructure like CI/CD, build and deployment scripts + [priority] High labels Feb 3, 2025
@achave11-ucsc achave11-ucsc removed the bug label Feb 11, 2025
@achave11-ucsc
Copy link
Member

achave11-ucsc commented Feb 11, 2025

This may also be related to recent GitHub actions failures intended to automatically create the promotion issue.

Two similar occurrences:
https://github.com/DataBiosphere/azul/actions/runs/13268414895/job/37041695337,
https://github.com/DataBiosphere/azul/actions/runs/13268830783/job/37043095132

Run python3 .github/workflows/schedule.py
2025-02-11 17:05:29,496    INFO azul.github.schedule: Issue template .github/ISSUE_TEMPLATE/fedramp_inventory_review.md is ineligible
2025-02-11 17:05:29,496    INFO azul.github.schedule: Issue template .github/ISSUE_TEMPLATE/public_access_content_review.md is ineligible
2025-02-11 17:05:29,496    INFO azul.github.schedule: Running ['gh', 'issue', 'list', '--search=in:title "Promotion 2025-02-11"', '--json=number', '--limit=10']
2025-02-11 17:05:29,887    INFO azul.github.schedule: Running ['gh', 'issue', 'create', '--title=Promotion 2025-02-11', '--body=- [ ] The title of this issue matches `Promotion yyyy-mm-dd`\n- [ ] For `prod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n- [ ] For `anvilprod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n', '--label=-,infra,no demo,operator,orange,task'] …
could not add label: 'task' not found
Traceback (most recent call last):
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 249, in <module>
    main(sys.argv[1:])
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 243, in main
    self.create_issue(now.date())
  File "/home/runner/work/azul/azul/.github/workflows/schedule.py", line 191, in create_issue
    process = subprocess.run(command, check=True, stdout=subprocess.PIPE)
  File "/usr/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['gh', 'issue', 'create', '--title=Promotion 2025-02-11', '--body=- [ ] The title of this issue matches `Promotion yyyy-mm-dd`\n- [ ] For `prod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n- [ ] For `anvilprod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n', '--label=-,infra,no demo,operator,orange,task']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

@hannes-ucsc
Copy link
Member

hannes-ucsc commented Feb 11, 2025

The errors directly above are caused by the removal of certain labels, task among them, as part of #6889. To address this, that issue requires a first, partial PR that removes these labels from the issue templates (so that issues are created on schedule again) and another final PR to update the scheduled issue creation workflow to set the issue type based on information in the template.

The fix for this very issue here is most likely to elevate the permissions of azul-group or the token, which I believe we reduced as part of the compliance account review.

@hannes-ucsc
Copy link
Member

The error in the description was for a issue created in azul-private. The azul-group account had no permissions at all for that repo. I readded it with Triage permissions. In the azul repo, azul-group has Write permissions but that is so that GL can post commit statuses.

@hannes-ucsc hannes-ucsc added the demo [process] To be demonstrated at the end of the sprint label Feb 12, 2025
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Feb 12, 2025

For demo, ensure that scheduled issues have labels, in azul and azul-private. Demo blocked on #6889, but only the on the first partial PR #6896.

@hannes-ucsc hannes-ucsc added the demo blocked [process] Demo is blocked by ongoing work label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+ [priority] High demo blocked [process] Demo is blocked by ongoing work demo [process] To be demonstrated at the end of the sprint infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

3 participants