-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt-core 1.5.x and 1.6.0 support #36
Conversation
c39fa3f
to
9650a07
Compare
@robastel feel free to review. |
Thanks for submitting this pull request @ciklista ! I need a bit of time to review. It looked like a lot of changes, but I see much of it is just changing single quotes to double quotes, as you mentioned. Black has an option For example, I use that option in the lint job here: https://github.com/Dashlane/dbt-invoke/blob/c749c72698083e39f2d85659ca225c99235b8968/.github/workflows/test.yml#L26C8-L26C8 Are you able to use that option to get rid of the quote changes (or at least separate them into their own commit) so that it is easier to review? I want avoid overlooking an actual logic change in the sea of quote changes. Thanks again for taking this on! |
d7c1fa9
to
4aa2234
Compare
Thanks for the feedback @robastel, I reverted the quotes changes. |
@robastel did you have the chance to look into the code? Are there any open questions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the review delay @ciklista and thanks again for this PR!
The general structure makes sense to me.
I have left some comments/suggestions for you to consider. Feel free to push back if there is anything you disagree with or feel should be considered separately from this PR.
f73164a
to
0fd84b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ciklista !
Adding support for dbt-core 1.5.x
dbt-core
. For older versions ofdbt-core
, users would have to install priordbt-invoke
versions.Given the many changes in the dbt-core API, I'd argue that backwards compatibility increases code complexity of this project to the extend that it becomes to much of a burden to keep the code clean and simple. Also, this allows for a cleaner cut to switch to
dbt-duckdb
for testing.Addresses #34
Changes:
dbt-duckdb
for testingdbt_scd_id
anddbt_updated_at
)