improvements on (audio) track selection #4707
Open
+415
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
requested changes
Mar 4, 2025
| @@ -998,14 +998,11 @@ import Events from './events/Events.js'; | |||
| * - Constants.TRACK_SWITCH_MODE_NEVER_REPLACE | |||
| * Do not replace existing segments in the buffer | |||
| * | |||
| * @property {string} [selectionModeForInitialTrack="highestSelectionPriority"] | |||
| * @property {string} [selectionModeForInitialTrack="highestEfficiency"] | |||
There was a problem hiding this comment.
Can we keep highestSelectionPriority as an option here. I would still like to give applications the chance to ignore selectionPriority if required. With the changes here and below we always use selectionPriority regardless of the configured mode
There was a problem hiding this comment.
Done - see the newly introduced ignoreSelectionPriority flag
| result.push(track); | ||
| } | ||
| }); | ||
| if ( trackArr[0] && (trackArr[0].type === Constants.VIDEO) ) { |
There was a problem hiding this comment.
Please split this logic into two separate functions one for audio and one for video which are then called here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this improves track selection as discussed here: #4701