Add unit tests

Dash-Industry-Forum · Mar 4, 2025 · 7d22d40 · 7d22d40
1 parent 43946e3
commit 7d22d40
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/dash/models/DashManifestModel.js b/src/dash/models/DashManifestModel.js
@@ -542,6 +542,9 @@ function DashManifestModel() {
             return null
         }
         const frameRate = realRepresentation[DashConstants.FRAMERATE];
+        if (!frameRate) {
+            return null
+        }
 
         if (typeof frameRate === 'string' && frameRate.includes('/')) {
             const [numerator, denominator] = frameRate.split('/').map(value => parseInt(value, 10));

diff --git a/test/unit/test/dash/dash.models.DashManifestModel.js b/test/unit/test/dash/dash.models.DashManifestModel.js
@@ -1665,11 +1665,16 @@ describe('DashManifestModel', function () {
 
         describe('getFramerate()', () => {
 
-            it('Should be undefined when no Representation is provided', () => {
+            it('Should be null when no Representation is provided', () => {
                 const framerate = dashManifestModel.getFramerate();
                 expect(framerate).to.be.null;
             })
 
+            it('Should be null when not defined', () => {
+                const framerate = dashManifestModel.getFramerate({});
+                expect(framerate).to.be.null;
+            })
+
             it('Should parse single integer', () => {
                 const framerate = dashManifestModel.getFramerate({frameRate: '24'});
                 expect(framerate).to.be.equal(24);