fix: Changed usage of deprecated zircote methods #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80dc5ce to
e5d25ca
Compare
|
Hey! Thank for PR, but I am going to introduce this change with more bigger changes in this PR and this will be new major version: https://github.com/DarkaOnLine/L5-Swagger/pull/618/files#diff-4ee5eaad222ef0782fccd29473a5f1860988b7cf91cdcd0a12628b2377972b36R239 |
|
Hi, thanks for the info 🙂 closing the PR then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes how a processor is registered into openApi Pipe. Previously, a deprecated method was used which is no longer present in new version of zircote/swagger-php lib.
Note, that this change prepares this library for zircote/swagger-php v5, but does not fix the last incompatible change - usage of
TokenAnalyser(AnalyserInterface) which is no longer available in the newer version.