Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchNamesWithUnderscores for Insert and Update #605

Closed
wants to merge 1 commit into from

Conversation

pdcmoreira
Copy link

Insert and Update now take in consideration the DefaultTypeMap.MatchNamesWithUnderscores option and follow the model properties' PascalCase to table columns' snake_case convention. #515

@rhubley
Copy link

rhubley commented Oct 11, 2016

looks like there are several AppendColumnNameEqualsValue methods, you only fixed one to be columnName = @propertyName the rest are still columnName = @columnName

@pdcmoreira
Copy link
Author

@rhubley I've changed several occurrences:
https://github.com/StackExchange/dapper-dot-net/pull/605/files

Can you please check? I might have missed something, but it's currently working for Insert and Update.

@NickCraver
Copy link
Member

The general problem with supporting this is that functionality was one way (reading). To respect it writing it a breaking change and I'm not sure it's a good one. I'm going to close this out in favor of something else: I think we need a [Column] attribute to solve this in a very general way for everyone. There are quite a few issues in it and it makes a more direct and explicit solution available for all.

A link to the v2 planning should appear below this shortly for discussions which are very welcome. We want your input. If you don't agree with this general solution, ping me and I'll reopen this...just trying to consolidate a lot of activity for v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants