Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapper.Contrib Nullable ID (#581) #1438

Closed
wants to merge 2 commits into from

Conversation

jurakovic
Copy link

@jurakovic jurakovic commented Apr 16, 2020

Added support for Nullable ID property in Dapper.Contrib
Fix for issue #581

@NickCraver
Copy link
Member

NickCraver commented May 2, 2020

Can you please provide any tests illustrating the use case this fixes?

@jurakovic
Copy link
Author

I have added InsertUserNullableId test
For some reason i cannot run tests in VS. No errors are shown so I don't know where is the problem :/
But I have tested it somehow outside of solution and it passes :)

@gilb195
Copy link

gilb195 commented May 28, 2020

I've been experiencing this issue as well since I'm using a nullable int for the ID in my models. Thank you @jurakovic for this PR - would love to see this merged and fixed soon.

@NickCraver NickCraver changed the base branch from master to main June 20, 2020 13:25
@NickCraver
Copy link
Member

I can't speak to Contrib's future plans here and if this is a good fit, but please see #1658 - Dapper.Contrib is not located at https://github.com/DapperLib/Dapper.Contrib (separate from this repository).

Note: I based the Dapper.Contrib fork on the original codebase which hopefully makes porting pull requests against the main branch there much easier - the intent was to split, not throw away work the community wants to go with.

@NickCraver NickCraver closed this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants