Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ISqlAdapter Insert contract to return a long instead of int #1386

Closed
wants to merge 2 commits into from
Closed

Change ISqlAdapter Insert contract to return a long instead of int #1386

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2019

Fix for #1385

@ghost ghost changed the title Change ISqlAdapter Insert contract to return a long instead of int #1385 Change ISqlAdapter Insert contract to return a long instead of int Dec 18, 2019
@NickCraver
Copy link
Member

Hey there! Unfortunately, this is a breaking change we can't make - it's something we're likely to change the workings on in v3 (see #722), but changing the interface here would break all consumers so it's not a change we can take to the lib until a major version...which will get a refactor when time allows anyhow.

@ghost ghost closed this Dec 24, 2019
@ghost ghost reopened this Dec 24, 2019
@NickCraver NickCraver changed the base branch from master to main June 20, 2020 13:25
@NickCraver
Copy link
Member

I can't speak to Contrib's future plans here and if this is a good fit, but please see #1658 - Dapper.Contrib is not located at https://github.com/DapperLib/Dapper.Contrib (separate from this repository).

Note: I based the Dapper.Contrib fork on the original codebase which hopefully makes porting pull requests against the main branch there much easier - the intent was to split, not throw away work the community wants to go with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants