Skip to content

Commit

Permalink
se eliminan lineas innecesarias
Browse files Browse the repository at this point in the history
  • Loading branch information
DannitaZz committed Feb 4, 2022
1 parent 2473772 commit 2f12520
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 66 deletions.
75 changes: 15 additions & 60 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,70 +1,25 @@
# Getting Started with Create React App
# PokeData

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
![Pokemon](src/img/pokeball.png)

## Available Scripts
Proyecto realizado con React y Material-U consumiendo datos desde [PokéAPI](https://pokeapi.co/)

In the project directory, you can run:
## Características

### `npm start`
-Responsive
-Paginación
-Usuario y favoritos persistentes
-Vistas protegidas

Runs the app in the development mode.\
Open [http://localhost:3000](http://localhost:3000) to view it in your browser.
### Prospectos

The page will reload when you make changes.\
You may also see any lint errors in the console.
-Agregar más información a la vista detalles
-Desplegar

### `npm test`
### Cómo usar

Launches the test runner in the interactive watch mode.\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
Como el usuario es local, las credenciales de acceso son:

### `npm run build`
-user: ash_ketchum
-password: pikachu123

Builds the app for production to the `build` folder.\
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.\
Your app is ready to be deployed!

See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.

### `npm run eject`

**Note: this is a one-way operation. Once you `eject`, you can't go back!**

If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.

You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.

## Learn More

You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

To learn React, check out the [React documentation](https://reactjs.org/).

### Code Splitting

This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting)

### Analyzing the Bundle Size

This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size)

### Making a Progressive Web App

This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app)

### Advanced Configuration

This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration)

### Deployment

This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment)

### `npm run build` fails to minify

This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify)
4 changes: 2 additions & 2 deletions src/components/pages/login.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ export default function SignIn({state, dispatch}) {

if (((currentUser===realUser) && (currentPass===realPass))){
dispatch({type:'login'})
console.log('correct credentials')
//console.log('correct credentials')
navigateTo('/')
} else{
console.log('bad credentials')
//console.log('bad credentials')
}
};

Expand Down
7 changes: 3 additions & 4 deletions src/components/pokedetails.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Typography, Card, CardContent, CardMedia } from '@mui/material';

import Chip from '@mui/material/Chip';
import Stack from '@mui/material/Stack';
import Box from '@mui/material/Box'
import { ReactComponent as Bug } from '../img/bug.svg'
import { ReactComponent as Dark } from '../img/dark.svg'
import { ReactComponent as Dragon } from '../img/dragon.svg'
Expand Down Expand Up @@ -79,9 +78,9 @@ function Pokedetails({ pokemon, dispatch }) {
let typeOneColor
let typeTwoColor
const highestStat = Math.max(...pokemon.stats.map((item) => item.base_stat))
console.log(highestStat)
// console.log(highestStat)

if (pokemon.types.length == 2) {
if (pokemon.types.length === 2) {
typeOneColor = typeColors[String(pokemon.types[0].type.name)]
typeTwoColor = typeColors[String(pokemon.types[1].type.name)]
} else {
Expand Down Expand Up @@ -147,7 +146,7 @@ function Pokedetails({ pokemon, dispatch }) {
getPokeData();

}
, [])
, [id, dispatch])

return (
<>
Expand Down

0 comments on commit 2f12520

Please sign in to comment.