Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Throwing RandomDataGeneratorException instead of None.get #7

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

yoohaemin
Copy link
Contributor

Fix #6

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #7 into master will increase coverage by 2.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   82.14%   84.37%   +2.23%     
==========================================
  Files           5        5              
  Lines          28       32       +4     
  Branches        1        1              
==========================================
+ Hits           23       27       +4     
  Misses          5        5
Impacted Files Coverage Δ
...omdatagenerator/magnolia/RandomDataGenerator.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3217c7...f0e7b9d. Read the comment docs.

Copy link
Owner

@DanielaSfregola DanielaSfregola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yoo-haemin,
thanks for contributing!

LGTM ;)

@DanielaSfregola DanielaSfregola merged commit c9dde7d into DanielaSfregola:master Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants