-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Unsigned Integer Data Types and Expand Documentation. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README has been updated to include an example of how to use the pandas-pyarrow library. This provides a specific illustration of handling problematic data types like float16 or db-dtypes that can cause issues in PyArrow, aiding users to fully exploit the library's benefits. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
The minimum version for the pyarrow dependency in the pyproject.toml file has been updated from "7.0.0" to "10.0.1". Users are now required to use at least version 10.0.1 of pyarrow in order to prevent potential compatibility issues. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
The numeric_mapper method in the pandas_pyarrow mappers module now includes the 'uint' data type. This enables mapping unsigned integer types with 8, 16, 32, and 64 bit variants. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Refactored the pandas-pyarrow tests for better coverage and efficiency. In particular, common and uncommon data types are now handled separately in the testing process. The tests were also updated to use the `convert_to_pyarrow` function, replacing the old `PandasArrowConverter` class. Finally, more comprehensive testing was made possible by expanding the range of test data types. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
This commit updates the tests for `pandas-pyarrow` to use the `convert_to_pyarrow` function instead of the previously used `SchemArrow`. Additionally, it changes `DateTimeMapper` to `datetime_mapper` for better efficiency. These changes enhance coverage and efficiency in testing, as well as broaden the range of test data types. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
The conversion process has been refactored for the tests in the pandas-pyarrow package. Instead of creating a PandasArrowConverter object for each test case, the convert_to_pyarrow function is directly used for converting the dataframes. This simplification makes the tests more straightforward and potentially more efficient. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Three new test cases for numeric types i.e., float16, uint16 and complex64 have been added in the pandas-pyarrow package testing. These additions will ensure the tested coverage and compatibility of these data types within the pandas-pyarrow integration. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Variables `float`, `float32`, and `float64` have been moved from the `COMMON_DTYPES_SAMPLE` to the `UNCOMMON_DTYPES_SAMPLE` list within the pandas-pyarrow testing suite. This rearrangement better illustrates which datatypes can be converted to PyArrow via the pandas API and which cannot, thus improving testing accuracy and clarity. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 57 57
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.