Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #475 #476

Merged
merged 4 commits into from
Jan 4, 2025
Merged

Fix #475 #476

merged 4 commits into from
Jan 4, 2025

Conversation

w568w
Copy link
Member

@w568w w568w commented Jan 4, 2025

This PR:

  1. implements reference counting for Watermark, allowing it to automatically hide when no longer required by any pages or widgets;
  2. only sends ViewStateChanged.INVISIBLE event to the tab page that was just switched away from, to ensure that each page receives a matching and equal number of VISIBLE and INVISIBLE events.

Fixes #475.

w568w added 3 commits January 4, 2025 16:31
…ched away from

This ensures that each page receives a matching and equal number of VISIBLE and INVISIBLE events.
…matic hiding when it's no longer needed by any page or widget

This fixes #475.
…d; make the current parameter for addWatermark default
@w568w w568w requested review from HydrogenC and Boreas618 January 4, 2025 08:37
@Boreas618
Copy link
Collaborator

LGTM

@w568w w568w merged commit 2c81401 into main Jan 4, 2025
@w568w w568w deleted the fix-475 branch January 4, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 水印只应出现在树洞和蛋壳
2 participants