Revert "fix: now when user pulls to refresh while in "only this person" mode, it will automatically quit." and fix it #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n" mode, it will automatically quit." This reverts commit 8f88a74.
w568w
commented
Jan 3, 2025
There was a problem hiding this comment.
This commit really shouldn't be called a "refactor" – it doesn't actually involve any refactoring, which is a software-engineering thing.
If you've accidentally committed the wrong changes and messed up the commit history, a better way to handle it is to fix the Git history locally and then force push to completely remove the commit(s) that caused the mess.
While this isn't an option in many repositories, it's acceptable to do in this project. (In repositories where force pushing is prohibited, the best practice is to close the PR, clean up the history, put the changes on a new branch, and open a fresh PR with the new branch.)
… will automatically quit.
04e03cb to
22e00c4
Compare
…only DZ, the state will not be reset since the first floor is always on the first page.
|
this should work. @w568w |
|
LGTM. Thanks for the efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f88a74.
Also, this PR isn't solely for reverting the commit; it also aims to fix it and properly address the issue mentioned in #473. I'm marking it as a draft for now since this part isn't complete yet.