Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add function security option to postgres function. #62

Merged
merged 1 commit into from
May 27, 2024
Merged

feat: Add function security option to postgres function. #62

merged 1 commit into from
May 27, 2024

Conversation

DanCardin
Copy link
Owner

@DanCardin DanCardin commented May 21, 2024 •
edited
Loading

Fixes #59

@DanCardin DanCardin force-pushed the dc/function-security branch from 7e58f30 to cb1dd9b Compare May 21, 2024 19:18
@coveralls
Copy link

coveralls commented May 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9260324924

Details

  • 29 of 31 (93.55%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on dc/function-security at 96.605%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sqlalchemy_declarative_extensions/dialects/postgresql/function.py 22 23 95.65%
src/sqlalchemy_declarative_extensions/function/base.py 6 7 85.71%
Totals Coverage Status
Change from base Build 9260321741: 96.6%
Covered Lines: 2522
Relevant Lines: 2603
💛 - Coveralls

@DanCardin DanCardin marked this pull request as ready for review May 21, 2024 19:38
@DanCardin DanCardin force-pushed the dc/function-security branch from cb1dd9b to 0e34139 Compare May 27, 2024 21:17
@DanCardin DanCardin merged commit 23383bb into main May 27, 2024
17 checks passed
@DanCardin DanCardin deleted the dc/function-security branch May 27, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: add SECURITY DEFINER to the postgresql Function
2 participants
@DanCardin @coveralls