Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Subreddit Removal Reasons #98

Merged
merged 18 commits into from
Jul 17, 2020
Merged

Add support for Subreddit Removal Reasons #98

merged 18 commits into from
Jul 17, 2020

Conversation

Dan6erbond
Copy link
Owner

Closes #94

Feature Summary

Explain what's new in this pull request.

class SubredditRemovalReasons / class SubredditRemovalReason:

  • SubredditRemovalReasons.get(item: str) to retrieve a removal reason by ID.
  • Implement __aiter__ and __anext__ to be used as an async generator.
  • SubredditRemovalReason.update() and delete() to update and delete items.

Other:

  • Refactor get_request() and post_request() in class Reddit and class RequestHandler to get()/post().
  • Add put() and delete() to class Reddit and class RequestHandler.
  • Update return types of class RequestHandler request methods.
  • Fix class Comment usage of ReactivePy. Add _async_update in place of _update for updates after fetch().
  • Optimize imports.

Tests Added

Describe tests if any were written.

  • test_subreddit_removal_reasons and test_subreddit_removal_reasons_add_delete.
  • test_subreddit_hot to test limit in special listings.

@Dan6erbond Dan6erbond added endpoint Addition or improvement of an API endpoint feature Helper functions or features for the wrapper labels Jul 17, 2020
@Dan6erbond Dan6erbond merged commit 62987f9 into master Jul 17, 2020
@Dan6erbond Dan6erbond deleted the issues/94 branch July 17, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endpoint Addition or improvement of an API endpoint feature Helper functions or features for the wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add removal reasons classes!
1 participant