Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for null in ui4t operations #875

Merged
merged 2 commits into from
May 9, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented May 9, 2024

adds support for parsing null string to null object. tested operations

  • generic column op
  • case when op
  • filter op
  • replace op

Correspondingdbt-automation PR - DalgoT4D/dbt-automation#119

@Ishankoradia Ishankoradia linked an issue May 9, 2024 that may be closed by this pull request
@Ishankoradia Ishankoradia requested review from fatchat and mdshamoon May 9, 2024 06:15
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 44.73%. Comparing base (12dc061) to head (0081ef5).

Files Patch % Lines
...Components/OperationPanel/Forms/CaseWhenOpForm.tsx 16.66% 5 Missing ⚠️
...nents/OperationPanel/Forms/GenericColumnOpForm.tsx 25.00% 3 Missing ⚠️
...ponents/OperationPanel/Forms/WhereFilterOpForm.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   44.73%   44.73%           
=======================================
  Files          77       77           
  Lines        5314     5322    +8     
  Branches     1232     1236    +4     
=======================================
+ Hits         2377     2381    +4     
- Misses       2803     2807    +4     
  Partials      134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit 72b3756 into main May 9, 2024
3 checks passed
@fatchat fatchat deleted the 772-add-null-to-column-value-selection branch May 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add NULL to column / value selection
3 participants