Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the desitnation form rendering issue #1356

Merged

Conversation

himanshudube97
Copy link
Contributor

@himanshudube97 himanshudube97 commented Dec 20, 2024

  1. Changed the numbering system :
    Earlier we were doing:
    Parent { order:1}:
    ChildA {order: 1.1}
    ChildB {order: 1.1}
    ChildC {order: 1.1}
    Parent {order:2}:
    ChildA {order: 2.1}
    ChildB {order: 2.1}
    ChildC {order: 2.1}

Issue was when Child 1.1 had grandchild
Parent {order:1}:
ChildA {order: 1.1}
GrandChild {order: 1.2}. Now this 1.2 was being rendered below ChildC (we did a sort()). This was messing up the order.
ChildB {order: 1.1}
ChildC {order: 1.1}
Parent {order:2}:
ChildA {order: 2.1}
ChildB {order: 2.1}
ChildC {order: 2.1}

      New format: I thought of just numbering them in sequence 1, 2, 3, 4, and so on

Parent {order:1}:
ChildA {order: 2}
GrandChild 3. Now this 1.2 was being rendered below ChildC (we did a sort()). This was messing up the order.
ChildB {order: 4}
ChildC {order: 5}
Parent {order:6}:
ChildA {order: 7}
ChildB {order: 8}
ChildC {order: 9}

      This way our order is also preserved and we can render in sequence.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.25%. Comparing base (9a93706) to head (b3e91df).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   71.25%   71.25%           
=======================================
  Files         102      102           
  Lines        7188     7188           
  Branches     1590     1642   +52     
=======================================
  Hits         5122     5122           
  Misses       2037     2037           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia
Copy link
Contributor

Beautiful !!

@Ishankoradia Ishankoradia self-requested a review December 22, 2024 05:13
@Ishankoradia Ishankoradia merged commit 5fc358c into main Dec 22, 2024
4 of 5 checks passed
@Ishankoradia Ishankoradia deleted the revert-1352-1350-bigquery-destination-form-showing-undefined branch December 22, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants