Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ssl connection switch #1338

Conversation

himanshudube97
Copy link
Contributor

No description provided.

@himanshudube97 himanshudube97 linked an issue Nov 28, 2024 that may be closed by this pull request
@himanshudube97 himanshudube97 self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (4ec2555) to head (9d0c582).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ConfigInput/ConfigInput.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
- Coverage   71.19%   71.14%   -0.05%     
==========================================
  Files         102      102              
  Lines        7154     7159       +5     
  Branches     1627     1630       +3     
==========================================
  Hits         5093     5093              
- Misses       1939     1944       +5     
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97
Copy link
Contributor Author

@fatchat It works perfectly now. My local airbyte was not upgraded thats why it didn't show the extra two fields that was in the response.

  • I Checked the staging airbyte, and there the fields were present. So we need NOT to to filter out any fields.

Airbyte postgres destination form.
Screenshot 2024-12-05 at 2 07 28 AM

@Ishankoradia Ishankoradia merged commit 01fe34a into main Dec 5, 2024
3 of 5 checks passed
@Ishankoradia Ishankoradia deleted the 763-warehouse-details-dont-show-ssl-connection-when-its-enabled branch December 5, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warehouse details don't show ssl-connection when it's enabled
2 participants